[MERGE #5583 @rhuanjl] Add end of file new line check fix #496

Merge pull request #5583 from rhuanjl:endOfFile

Per issue #496 augment the existing line ending check to also check to ensure that each file ends in a newline.

Note, per logic in check_eol.sh this test is run only on:
1. Files edited in the current PR
2. Files that are not JS test files OR any cmd, baseline, wasm, vcxproj or sln files

Also note:
1. As this runs only on files edited din current PR it won't catch any historic mistakes
2. It doesn't check JS test files - this seemed odd to me but chose to leave it

CC @dilijev

Build/Chakra.Build.Clang.targets

@@ -126,4 +126,4 @@
     >
     </CL>
   </Target>
-</Project>
+</Project>

Build/NuGet/Microsoft.ChakraCore.vc140.targets

@@ -37,4 +37,4 @@
     <ReferenceCopyLocalPaths Include="$(MSBuildThisFileDirectory)..\..\lib\native\v140\x86\Release\ChakraCore.dll" />
     <ReferenceCopyLocalPaths Include="$(MSBuildThisFileDirectory)..\..\lib\native\v140\x86\Release\ChakraCore.pdb" />
   </ItemGroup>
-</Project>
+</Project>

Build/NuGet/package.ps1

@@ -47,4 +47,4 @@ Foreach ($nuspec in $(Get-Item $packageRoot\*.nuspec))
 If (Test-Path $compiledNuspec)
 {
     Remove-Item $compiledNuspec
-}
+}

bin/ch/262.js

@@ -28,4 +28,4 @@ var $262 = {
     getReport: function () { return WScript.GetReport(); },
   },
 };
-)===="
+)===="

jenkins/check_eol.sh

@@ -15,7 +15,7 @@ fi
 ERRFILE=check_eol.sh.err
 rm -f $ERRFILE
 
-git diff --name-only `git merge-base origin/master HEAD` HEAD | grep -v -E "(test/.*\\.js|\\.cmd|\\.baseline|\\.wasm|\\.vcxproj|\\.vcproj|\\.sln)" | xargs -I % ./jenkins/check_file_eol.sh %
+git diff --name-only `git merge-base origin/master HEAD` HEAD | grep -v -E "(test/.*\\.js|\\.cmd|\\.baseline|\\.wasm|\\.wast|\\.vcxproj|\\.vcproj|\\.sln)" | xargs -I % ./jenkins/check_file_eol.sh %
 
 if [ -e $ERRFILE ]; then # if error file exists then there were errors
     >&2 echo "--------------" # leading >&2 means echo to stderr

jenkins/check_file_eol.sh

@@ -37,4 +37,10 @@ if [ $? -eq 0 ]; then # grep found matches ($?==0), so we found CR (0x0d) in the
     echo "--------------" >> $ERRFILE # same length as '--- ERRORS ---'
 fi
 
+# Check that each file ends in a newline character
+tail -c1 $1 | od -x | grep '000a' > $ERRFILETEMP
+if [ $? -ne 0 ]; then # last character is not a newline
+    echo "ERROR: $1 does not end in a new line" >> $ERRFILE
+fi
+
 rm -f $ERRFILETEMP

lib/Backend/AsmJsJITInfo.cpp

@@ -97,4 +97,4 @@ AsmJsJITInfo::AccessNeedsBoundCheck(uint offset) const
 {
     return offset >= 0x10000;
 }
-#endif
+#endif

lib/Backend/BackendOpCodeAttrAsmJs.cpp

@@ -68,4 +68,4 @@ namespace OpCodeAttrAsmJs
     }
 
 }; // OpCodeAttrAsmJs
-#endif
+#endif

lib/Backend/BackendOpCodeAttrAsmJs.h

@@ -12,4 +12,4 @@ namespace OpCodeAttrAsmJs
     bool HasProfiledOp(Js::OpCodeAsmJs opcode);
     bool IsProfiledOp(Js::OpCodeAsmJs opcode);
 };
-#endif
+#endif

lib/Backend/CodeGenNumberAllocator.cpp

@@ -571,4 +571,4 @@ XProcNumberPageSegmentManager::~XProcNumberPageSegmentManager()
         temp = (XProcNumberPageSegmentImpl*)next;
     }
 }
-#endif
+#endif

lib/Backend/EquivalentTypeSet.cpp

@@ -162,4 +162,4 @@ void EquivalentTypeSet::SortAndRemoveDuplicates()
     this->sortedAndDuplicatesRemoved = true;
 }
 }
-#endif
+#endif

lib/Backend/GlobOpt.cpp

@@ -17464,4 +17464,4 @@ void GlobOpt::PRE::TraceFailedPreloadInLandingPad(const Loop *const loop, Proper
         Output::Print(_u("\n"));
     }
 }
-#endif
+#endif

lib/Backend/GlobOptIntBounds.cpp

@@ -3242,4 +3242,4 @@ GlobOpt::EmitIntRangeChecks(IR::Instr* instr)
         EmitIntRangeChecks(instr, instr->GetDst());
     }
 }
-#endif
+#endif

lib/Backend/IRBuilderAsmJs.h

@@ -314,4 +314,4 @@ class IRBuilderAsmJs
 #undef Uint8x16Type
 };
 
-#endif
+#endif

lib/Backend/JitTransferData.cpp

@@ -115,4 +115,4 @@ void JitTransferData::Cleanup()
         }
         midl_user_free(entries);
     }
-}
+}

lib/Backend/JitTransferData.h

@@ -111,4 +111,4 @@ class JitTransferData
     void Cleanup();
 private:
     void EnsureJitTimeTypeRefs(Recycler* recycler);
-};
+};

lib/Backend/LowerMDShared.cpp

@@ -8633,4 +8633,4 @@ IR::BranchInstr*
 LowererMD::InsertMissingItemCompareBranch(IR::Opnd* compareSrc, IR::Opnd* missingItemOpnd, Js::OpCode opcode, IR::LabelInstr* target, IR::Instr* insertBeforeInstr)
 {
     return this->lowererMDArch.InsertMissingItemCompareBranch(compareSrc, missingItemOpnd, opcode, target, insertBeforeInstr);
-}
+}

lib/Backend/LowerMDSharedSimd128.cpp

@@ -3306,4 +3306,4 @@ BYTE LowererMD::Simd128GetTypedArrBytesPerElem(ValueType arrType)
     return  (1 << Lowerer::GetArrayIndirScale(arrType));
 }
 
-#endif
+#endif

lib/Backend/NativeEntryPointData.cpp

@@ -566,4 +566,4 @@ OOPNativeEntryPointData::DeleteNativeDataBuffer(char * nativeDataBuffer)
     midl_user_free(buffer);
 }
 
-#endif
+#endif

lib/Backend/NativeEntryPointData.h

@@ -214,4 +214,4 @@ class OOPNativeEntryPointData : public NativeEntryPointData
 #endif
 };
 
-#endif
+#endif

lib/Backend/amd64/LowererMDArch.cpp

@@ -3466,4 +3466,4 @@ LowererMDArch::InsertMissingItemCompareBranch(IR::Opnd* compareSrc, IR::Opnd* mi
     }
 
     return this->lowererMD->m_lowerer->InsertCompareBranch(missingItemOpnd, compareSrcUint64Opnd, opcode, target, insertBeforeInstr);
-}
+}

lib/Backend/amd64/machvalues.h

@@ -18,4 +18,4 @@ static const int MachStackAlignment = MachPtr;
 static const int MachArgsSlotOffset = MachPtr;
 static const int MachMaxInstrSize = 12;
 static const unsigned __int64 MachSignBit = 0x8000000000000000;
-static const int MachSimd128 = 16;
+static const int MachSimd128 = 16;

lib/Backend/arm/machvalues.h

@@ -16,4 +16,4 @@ static const int MachPtr = 4;
 static const int MachDouble = 8;
 static const int MachRegDouble = 8;
 static const int MachArgsSlotOffset = MachPtr;
-static const int MachStackAlignment = MachDouble;
+static const int MachStackAlignment = MachDouble;

lib/Backend/arm64/machvalues.h

@@ -18,4 +18,4 @@ static const int MachDouble = 8;
 static const int MachRegDouble = 8;
 static const int MachArgsSlotOffset = MachPtr;
 static const int MachStackAlignment = 16; // On ARM64 SP needs to be 16 byte aligned for load/store
-static const unsigned __int64 MachSignBit = 0x8000000000000000;
+static const unsigned __int64 MachSignBit = 0x8000000000000000;

lib/Backend/i386/LowererMDArch.cpp

@@ -4224,4 +4224,4 @@ LowererMDArch::InsertMissingItemCompareBranch(IR::Opnd* compareSrc, IR::Opnd* mi
     }
 
     return this->lowererMD->m_lowerer->InsertCompareBranch(missingItemOpnd, compareSrcUint32Opnd, opcode, target, insertBeforeInstr);
-}
+}

lib/Backend/i386/machvalues.h

@@ -18,4 +18,4 @@ static const int MachMaxInstrSize = 11;
 static const int MachArgsSlotOffset = MachPtr;
 static const int MachStackAlignment = MachDouble;
 static const unsigned int MachSignBit = 0x80000000;
-static const int MachSimd128 = 16;
+static const int MachSimd128 = 16;

lib/Common/Core/Assertions.h

@@ -140,4 +140,4 @@ struct IsSame<T1, T1>
     {
         IsTrue = true
     };
-};
+};

lib/Common/DataStructures/ClusterList.h

@@ -417,4 +417,4 @@ class SegmentClusterList
         Output::Print(_u("]\n"));
     }
 #endif
-};
+};

lib/Common/Memory/AllocatorTelemetryStats.h

@@ -42,4 +42,4 @@ struct AllocatorSizes
     size_t reservedBytes;
     size_t committedBytes;
     size_t numberOfSegments;
-};
+};

lib/Common/Memory/BucketStatsReporter.h

@@ -188,4 +188,4 @@ class BucketStatsReporter
 #endif
 };
 
-};
+};

lib/Common/Memory/CollectionState.h

@@ -102,4 +102,4 @@ enum CollectionState
     CollectionStateConcurrentMarkWeakRef = Collection_ConcurrentMark | Collection_ExecutingConcurrent | Collection_WeakRefMark,
 };
 
-}
+}

lib/Common/Memory/CustomHeap.cpp

@@ -1210,4 +1210,4 @@ CodePageAllocators<SectionAllocWrapper, PreReservedSectionAllocWrapper>::FreeLoc
 } // namespace CustomHeap
 
 } // namespace Memory
-#endif // ENABLE_NATIVE_CODEGEN || DYNAMIC_INTERPRETER_THUNK
+#endif // ENABLE_NATIVE_CODEGEN || DYNAMIC_INTERPRETER_THUNK

lib/Common/Memory/CustomHeap.h

@@ -579,4 +579,4 @@ BucketId GetBucketForSize(DECLSPEC_GUARD_OVERFLOW size_t bytes);
 void FillDebugBreak(_Out_writes_bytes_all_(byteCount) BYTE* buffer, _In_ size_t byteCount);
 } // namespace CustomHeap
 } // namespace Memory
-#endif
+#endif

lib/Common/Memory/DelayDeletingFunctionTable.cpp

@@ -78,4 +78,4 @@ void DelayDeletingFunctionTable::DeleteFunctionTable(void* functionTable)
     NtdllLibrary::Instance->DeleteGrowableFunctionTable(functionTable);
 }
 
-#endif
+#endif

lib/Common/Memory/HeapInfoManager.h

@@ -210,4 +210,4 @@ class HeapInfoManager
     size_t unusedPartialCollectFreeBytes;
 #endif
 };
-}
+}

lib/Common/Memory/RecyclerSweepManager.cpp

@@ -586,4 +586,4 @@ size_t RecyclerSweepManager::GetPendingMergeNewHeapBlockCount(HeapInfo const * h
 {
     return this->defaultHeapRecyclerSweep.GetPendingMergeNewHeapBlockCount(heapInfo);
 }
-#endif
+#endif

lib/Common/Memory/RecyclerSweepManager.h

@@ -97,4 +97,4 @@ RecyclerSweepManager::GetHeapBlockCount(HeapBucketT<TBlockType> const * heapBuck
     return this->defaultHeapRecyclerSweep.GetHeapBlockCount(heapBucket);
 }
 #endif
-};
+};

lib/Common/Memory/XDataAllocator.h

@@ -33,4 +33,4 @@ struct DelayDeletingFunctionTable
     static bool IsEmpty();
     static void DeleteFunctionTable(void* functionTable);
 };
-#endif
+#endif

lib/Jsrt/JsrtDebugEventObject.cpp

@@ -124,4 +124,4 @@ JsrtDebugDocumentManager::BreakpointDebugDocumentDictionary * JsrtDebugDocumentM
     }
     return breakpointDebugDocumentDictionary;
 }
-#endif
+#endif

lib/Jsrt/JsrtDebugManager.cpp

@@ -763,4 +763,4 @@ JsDiagDebugEvent JsrtDebugManager::GetDebugEventFromStopType(Js::StopType stopTy
 
     return JsDiagDebugEventBreakpoint;
 }
-#endif
+#endif

lib/Jsrt/JsrtDebugUtils.cpp

@@ -497,4 +497,4 @@ const char16 * JsrtDebugUtils::GetDebugPropertyName(JsrtDebugPropertyId property
     Assert(false);
     return _u("");
 }
-#endif
+#endif

lib/Jsrt/JsrtDebuggerObject.cpp

@@ -952,4 +952,4 @@ void JsrtDebugStackFrames::ClearFrameDictionary()
         this->framesDictionary->Clear();
     }
 }
-#endif
+#endif

lib/Parser/BGParseManager.cpp

@@ -650,4 +650,4 @@ void BGParseWorkItem::WaitForCompletion()
 
         this->complete->Wait();
     }
-}
+}

lib/Parser/BGParseManager.h

@@ -150,4 +150,4 @@ class BGParseWorkItem sealed : public JsUtil::Job
     // Output data
     byte * bufferReturn;
     DWORD  bufferReturnBytes;
-};
+};

lib/Parser/Parse.h

@@ -1210,4 +1210,4 @@ class Parser
 public:
     charcount_t GetSourceIchLim() { return m_sourceLim; }
     static BOOL NodeEqualsName(ParseNodePtr pnode, LPCOLESTR sz, uint32 cch);
-};
+};

lib/Parser/perrors.h

@@ -108,4 +108,4 @@ LSC_ERROR_MSG(1092, ERRLabelBeforeAsyncFncDeclaration, "Labels not allowed befor
 LSC_ERROR_MSG(1093, ERRLabelBeforeClassDeclaration, "Labels not allowed before class declaration")
 LSC_ERROR_MSG(1094, ERRLabelFollowedByEOF, "Unexpected end of script after a label.")
 LSC_ERROR_MSG(1095, ERRFunctionAfterLabelInStrict, "Function declarations not allowed after a label in strict mode.")
-LSC_ERROR_MSG(1096, ERRAwaitAsLabelInAsync, "Use of 'await' as label in async function is not allowed.")
+LSC_ERROR_MSG(1096, ERRAwaitAsLabelInAsync, "Use of 'await' as label in async function is not allowed.")

lib/Parser/ptree.h

@@ -1093,4 +1093,4 @@ template <OpCode nop> class OpCodeTrait;
         typedef ParseNode##nk ParseNodeType; \
         static const bool AllowDefer = ((ok) & fnopAllowDefer) != 0; \
     };
-#include "ptlist.h"
+#include "ptlist.h"

lib/Runtime/Base/PerfHintDescriptions.h

@@ -15,4 +15,4 @@ PERFHINT_REASON(HeapArgumentsDueToWriteToFormals,   true, PerfHintLevels::L1,
 PERFHINT_REASON(HeapArgumentsDueToNonLocalRef,      true, PerfHintLevels::L1,      _u("Arguments object not optimized as there were some nested functions or non-local refs found in nested functions"),  _u("Scope object creation is required in this case"), _u("Check for nested functions and non-local refs inside")  )
 PERFHINT_REASON(HeapArgumentsModification,          true, PerfHintLevels::L1,      _u("Modification to arguments"),              _u("Slower lookups, high overhead in the JIT code"), _u("Avoid modification to the arguments"))
 PERFHINT_REASON(HeapArgumentsCreated,               true, PerfHintLevels::L1,      _u("Arguments object not optimized"),         _u("Slower lookups, high overhead in the JIT code"), _u("Check the usage of arguments in the function"))
-PERFHINT_REASON(PolymorphicInilineCap,              true, PerfHintLevels::L1,      _u("Function has reached polymorphic-inline cap"), _u("This function will not inline more than 4 functions for this call-site."), _u("Check the polymorphic usage of this function"))
+PERFHINT_REASON(PolymorphicInilineCap,              true, PerfHintLevels::L1,      _u("Function has reached polymorphic-inline cap"), _u("This function will not inline more than 4 functions for this call-site."), _u("Check the polymorphic usage of this function"))

lib/Runtime/ByteCode/AsmJsByteCodeWriter.h

@@ -130,4 +130,4 @@ namespace Js
 #undef IMP_IWASM
 #endif
 
-#endif
+#endif

lib/Runtime/ByteCode/ByteCodeSerializeFlags.h

@@ -11,4 +11,4 @@
 // of these flags to indicate how to allocate the memory. The absence of both flags
 // indicates that no allocation is needed.
 #define GENERATE_BYTE_CODE_COTASKMEMALLOC   0x00000008
-#define GENERATE_BYTE_CODE_ALLOC_ANEW       0x00000010
+#define GENERATE_BYTE_CODE_ALLOC_ANEW       0x00000010

lib/Runtime/ByteCode/OpCodes.h

@@ -862,4 +862,4 @@ MACRO_EXTEND_WMS(       NewPropIdArrForCompProps, Reg1Unsigned1, OpSideEffect)
 #undef MACRO_WMS_WITH_DBG_ATTR
 #undef MACRO_EXTEND_WITH_DBG_ATTR
 #undef MACRO_EXTEND_WMS_WITH_DBG_ATTR
-#undef MACRO_BACKEND_ONLY_WITH_DBG_ATTR
+#undef MACRO_BACKEND_ONLY_WITH_DBG_ATTR

lib/Runtime/Debug/BreakpointProbe.cpp

@@ -86,4 +86,4 @@ namespace Js
         statement->statement.begin = this->characterOffset;
     }
 }
-#endif
+#endif

lib/Runtime/Debug/DebugContext.cpp

@@ -411,4 +411,4 @@ namespace Js
         });
     }
 }
-#endif
+#endif

lib/Runtime/Debug/DebugDocument.cpp

@@ -352,4 +352,4 @@ namespace Js
         return TRUE;
     }
 }
-#endif
+#endif

lib/Runtime/Debug/DebugManager.cpp

@@ -233,4 +233,4 @@ AutoSetDispatchHaltFlag::~AutoSetDispatchHaltFlag()
     Assert(m_scriptContext->GetDebugContext()->GetProbeContainer()->IsPrimaryBrokenToDebuggerContext());
     m_scriptContext->GetDebugContext()->GetProbeContainer()->SetIsPrimaryBrokenToDebuggerContext(false);
 }
-#endif
+#endif

lib/Runtime/Debug/DebuggingFlags.cpp

@@ -76,4 +76,4 @@ void DebuggingFlags::SetIsBuiltInWrapperPresent(bool value /* = true */)
 {
     m_isBuiltInWrapperPresent = value;
 }
-#endif
+#endif