[MERGE #5583 @rhuanjl] Add end of file new line check fix #496

Merge pull request #5583 from rhuanjl:endOfFile

Per issue #496 augment the existing line ending check to also check to ensure that each file ends in a newline.

Note, per logic in check_eol.sh this test is run only on:
1. Files edited in the current PR
2. Files that are not JS test files OR any cmd, baseline, wasm, vcxproj or sln files

Also note:
1. As this runs only on files edited din current PR it won't catch any historic mistakes
2. It doesn't check JS test files - this seemed odd to me but chose to leave it

CC @dilijev

Author: dilijev

Build/Chakra.Build.Clang.targets

@@ -126,4 +126,4 @@
     >
     </CL>
   </Target>
-</Project>
+</Project>

Build/NuGet/Microsoft.ChakraCore.vc140.targets

@@ -37,4 +37,4 @@
     <ReferenceCopyLocalPaths Include="$(MSBuildThisFileDirectory)..\..\lib\native\v140\x86\Release\ChakraCore.dll" />
     <ReferenceCopyLocalPaths Include="$(MSBuildThisFileDirectory)..\..\lib\native\v140\x86\Release\ChakraCore.pdb" />
   </ItemGroup>
-</Project>
+</Project>

Build/NuGet/package.ps1

@@ -47,4 +47,4 @@ Foreach ($nuspec in $(Get-Item $packageRoot\*.nuspec))
 If (Test-Path $compiledNuspec)
 {
     Remove-Item $compiledNuspec
-}
+}

bin/ch/262.js

@@ -28,4 +28,4 @@ var $262 = {
     getReport: function () { return WScript.GetReport(); },
   },
 };
-)===="
+)===="

jenkins/check_eol.sh

@@ -15,7 +15,7 @@ fi
 ERRFILE=check_eol.sh.err
 rm -f $ERRFILE
 
-git diff --name-only `git merge-base origin/master HEAD` HEAD | grep -v -E "(test/.*\\.js|\\.cmd|\\.baseline|\\.wasm|\\.vcxproj|\\.vcproj|\\.sln)" | xargs -I % ./jenkins/check_file_eol.sh %
+git diff --name-only `git merge-base origin/master HEAD` HEAD | grep -v -E "(test/.*\\.js|\\.cmd|\\.baseline|\\.wasm|\\.wast|\\.vcxproj|\\.vcproj|\\.sln)" | xargs -I % ./jenkins/check_file_eol.sh %
 
 if [ -e $ERRFILE ]; then # if error file exists then there were errors
     >&2 echo "--------------" # leading >&2 means echo to stderr

jenkins/check_file_eol.sh

@@ -37,4 +37,10 @@ if [ $? -eq 0 ]; then # grep found matches ($?==0), so we found CR (0x0d) in the
     echo "--------------" >> $ERRFILE # same length as '--- ERRORS ---'
 fi
 
+# Check that each file ends in a newline character
+tail -c1 $1 | od -x | grep '000a' > $ERRFILETEMP
+if [ $? -ne 0 ]; then # last character is not a newline
+    echo "ERROR: $1 does not end in a new line" >> $ERRFILE
+fi
+
 rm -f $ERRFILETEMP

lib/Backend/AsmJsJITInfo.cpp

@@ -97,4 +97,4 @@ AsmJsJITInfo::AccessNeedsBoundCheck(uint offset) const
 {
     return offset >= 0x10000;
 }
-#endif
+#endif

lib/Backend/BackendOpCodeAttrAsmJs.cpp

@@ -68,4 +68,4 @@ namespace OpCodeAttrAsmJs
     }
 
 }; // OpCodeAttrAsmJs
-#endif
+#endif

lib/Backend/BackendOpCodeAttrAsmJs.h

@@ -12,4 +12,4 @@ namespace OpCodeAttrAsmJs
     bool HasProfiledOp(Js::OpCodeAsmJs opcode);
     bool IsProfiledOp(Js::OpCodeAsmJs opcode);
 };
-#endif
+#endif

lib/Backend/CodeGenNumberAllocator.cpp

@@ -571,4 +571,4 @@ XProcNumberPageSegmentManager::~XProcNumberPageSegmentManager()
         temp = (XProcNumberPageSegmentImpl*)next;
     }
 }
-#endif
+#endif