Skip to content

Commit 8c98360

Browse files
committed
add some comments & todos, fix add a header to a project group
1 parent 12c4409 commit 8c98360

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

lib/Backend/LowerMDSharedSimd128.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2622,6 +2622,7 @@ IR::Instr* LowererMD::Simd128LowerAllTrue(IR::Instr* instr)
26222622
instr->InsertBefore(pInstr);
26232623

26242624
//horizontally OR into 0th and 2nd positions
2625+
//TODO nikolayk revisit the sequence for in64x2.alltrue
26252626
IR::Opnd* newDst = dst;
26262627
uint cmpMask = 0xFFFF;
26272628
if (instr->m_opcode == Js::OpCode::Simd128_AllTrue_B2)

lib/Runtime/Language/Chakra.Runtime.Language.vcxproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<?xml version="1.0" encoding="utf-8"?>
1+
<?xml version="1.0" encoding="utf-8"?>
22
<Project DefaultTargets="Build" ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<Import Condition="'$(ChakraBuildPathImported)'!='true'" Project="$(SolutionDir)Chakra.Build.Paths.props" />
44
<Import Project="$(BuildConfigPropsPath)Chakra.Build.ProjectConfiguration.props" />
@@ -241,6 +241,7 @@
241241
<ClInclude Include="JavascriptStackWalker.h" />
242242
<ClInclude Include="SimdFloat32x4Operation.h" />
243243
<ClInclude Include="SimdFloat64x2Operation.h" />
244+
<ClInclude Include="SimdInt64x2Operation.h" />
244245
<ClInclude Include="SimdInt32x4Operation.h" />
245246
<ClInclude Include="SimdInt16x8Operation.h" />
246247
<ClInclude Include="SimdInt8x16Operation.h" />

lib/Runtime/Language/SimdInt64x2Operation.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ namespace Js {
1212
static SIMDValue OpAdd(const SIMDValue& a, const SIMDValue& b);
1313
static SIMDValue OpSub(const SIMDValue& a, const SIMDValue& b);
1414
static SIMDValue OpNeg(const SIMDValue& a);
15+
16+
//pointer-based arguments are used to ensure that calling conventions are consistent across x86/x64
17+
//and match call sequences JIT generates.
18+
//TODO: nikolayk back to "const SIMDValue& a"
1519
static void OpShiftLeftByScalar(SIMDValue* dst, SIMDValue* src, int count);
1620
static void OpShiftRightByScalar(SIMDValue* dst, SIMDValue* src, int count);
1721
static void OpShiftRightByScalarU(SIMDValue* dst, SIMDValue* src, int count);

0 commit comments

Comments
 (0)