[MERGE #5799 @wyrichte] Fails AsmJs.cpp's module return check if a pr…

…operty definition in the return object literal is not a binary parse node.

Merge pull request #5799 from wyrichte:build/wyrichte/asm_async

lib/Runtime/Language/AsmJs.cpp

@@ -851,6 +851,11 @@ namespace Js
 
             if( member )
             {
+                if (!(member->Grfnop() & fnopBin))
+                {
+                    return m.Fail(node, _u("Return object member must be an assignment expression"));
+                }
+
                 ParseNode* field = ParserWrapper::GetBinaryLeft( member );
                 ParseNode* value = ParserWrapper::GetBinaryRight( member );
                 if( !ParserWrapper::IsNameDeclaration( field ) || !ParserWrapper::IsNameDeclaration( value ) )

test/AsmJs/notBinaryPropertyDefinition.baseline

@@ -0,0 +1,2 @@
+Return object member must be an assignment expression
+Asm.js compilation failed.

test/AsmJs/notBinaryPropertyDefinition.js

@@ -0,0 +1,9 @@
+//-------------------------------------------------------------------------------------------------------
+// Copyright (C) Microsoft Corporation and contributors. All rights reserved.
+// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
+//-------------------------------------------------------------------------------------------------------
+
+function f() {
+    "use asm";
+    return { ...a, b };
+}

test/AsmJs/rlexe.xml

@@ -987,6 +987,13 @@
       <compile-flags>-forcedeferparse -testtrace:asmjs</compile-flags>
     </default>
   </test>
+  <test>
+    <default>
+      <files>notBinaryPropertyDefinition.js</files>
+      <baseline>notBinaryPropertyDefinition.baseline</baseline>
+      <compile-flags>-ES2018ObjectRestSpread -testtrace:asmjs</compile-flags>
+    </default>
+  </test>
   <test>
     <default>
       <files>constbrbug.js</files>