CR feedback - call the virtual SetInternalProperty in DeferredTypeHandler::SetInternalProperty

rajatd · rajatd · commit b25f86d94f0d · 2017-08-25T11:50:03.000-07:00
diff --git a/lib/Runtime/Types/DeferredTypeHandler.h b/lib/Runtime/Types/DeferredTypeHandler.h
@@ -329,10 +329,7 @@ namespace Js
             return TRUE;
         }
 
-        DynamicTypeHandler * typeHandler = GetCurrentTypeHandler(instance);
-        return typeHandler->IsPathTypeHandler() ?
-            typeHandler->SetProperty(instance, propertyId, value, flags, nullptr) :
-            typeHandler->SetPropertyWithAttributes(instance, propertyId, value, PropertyWritable & PropertyConfigurable, nullptr, flags);
+        return GetCurrentTypeHandler(instance)->SetInternalProperty(instance, propertyId, value, flags);
     }
 
     template <DeferredTypeInitializer initializer, typename DeferredTypeFilter, bool isPrototypeTemplate, uint16 _inlineSlotCapacity, uint16 _offsetOfInlineSlots>

Original file line number	Diff line number	Diff line change
`@@ -329,10 +329,7 @@ namespace Js`
`329`	`329`	`return TRUE;`
`330`	`330`	`}`
`331`	`331`
`332`		`- DynamicTypeHandler * typeHandler = GetCurrentTypeHandler(instance);`
`333`		`- return typeHandler->IsPathTypeHandler() ?`
`334`		`- typeHandler->SetProperty(instance, propertyId, value, flags, nullptr) :`
`335`		`- typeHandler->SetPropertyWithAttributes(instance, propertyId, value, PropertyWritable & PropertyConfigurable, nullptr, flags);`
	`332`	`+ return GetCurrentTypeHandler(instance)->SetInternalProperty(instance, propertyId, value, flags);`
`336`	`333`	`}`
`337`	`334`
`338`	`335`	`template <DeferredTypeInitializer initializer, typename DeferredTypeFilter, bool isPrototypeTemplate, uint16 _inlineSlotCapacity, uint16 _offsetOfInlineSlots>`