[MERGE #5375 @dilijev] OS#10368428: Failfast if IsExternalUnicodeLibraryAvailable would return false.

Merge pull request #5375 from dilijev:fatal-unicode-lib-unavailable

The only caller of IsExternalUnicodeLibraryAvailable  (Js::CharClassifier::CharClassifier) will failfast when this method returns false, so move the failfast closer the cause of the problem to improve diagnosis and attribution by stack. Also create a specific failfast type for this failure mode to improve attribution.

Author: dilijev

lib/Common/Exceptions/Throw.cpp

@@ -77,6 +77,13 @@ namespace Js {
         ReportFatalException(NULL, E_FAIL, Fatal_Internal_Error, scenario);
     }
 
+    void Throw::FatalInternalGlobalizationError()
+    {
+        AssertMsg(false, "Failure in initializing Globalization library");
+        int scenario = 2;
+        ReportFatalException(NULL, E_FAIL, Fatal_Internal_Error, scenario);
+    }
+
     void Throw::FatalProjectionError()
     {
         RaiseException((DWORD)DBG_TERMINATE_PROCESS, EXCEPTION_NONCONTINUABLE, 0, NULL);

lib/Common/Exceptions/Throw.h

@@ -21,6 +21,8 @@ namespace Js {
         static void __declspec(noreturn) InternalError();
         static void __declspec(noreturn) FatalInternalError();
         static void __declspec(noreturn) FatalInternalErrorEx(int scenario);
+        static void __declspec(noreturn) FatalInternalGlobalizationError();
+
         static void __declspec(noreturn) FatalProjectionError();
 #if ENABLE_JS_REENTRANCY_CHECK
         static void __declspec(noreturn) FatalJsReentrancyError();

lib/Parser/CharClassifier.cpp

@@ -411,11 +411,11 @@ Js::CharClassifier::CharClassifier(void)
     bool isES6UnicodeModeEnabled = CONFIG_FLAG(ES6Unicode);
     bool isFullUnicodeSupportAvailable = PlatformAgnostic::UnicodeText::IsExternalUnicodeLibraryAvailable();
 
-#ifdef NTBUILD
+#if INTL_ICU || INTL_WINGLOB // don't assert in _no_icu builds (where there is no i18n library, by design)
     AssertMsg(isFullUnicodeSupportAvailable, "Windows.Globalization needs to present with IUnicodeCharacterStatics support for Chakra.dll to work");
     if (!isFullUnicodeSupportAvailable)
     {
-        Js::Throw::FatalInternalError();
+        Js::Throw::FatalInternalGlobalizationError();
     }
 #endif
 
@@ -450,7 +450,6 @@ Js::CharClassifier::CharClassifier(void)
         getBigCharFlagsFunc = &CharClassifier::GetBigCharFlagsES5;
     }
 #endif
-
 }
 
 const OLECHAR* Js::CharClassifier::SkipWhiteSpaceNonSurrogate(LPCOLESTR psz, const CharClassifier *instance)

lib/Runtime/PlatformAgnostic/Platform/Windows/UnicodeText.cpp

@@ -399,18 +399,31 @@ namespace PlatformAgnostic
                 Js::WindowsGlobalizationAdapter* globalizationAdapter = threadContext->GetWindowsGlobalizationAdapter();
                 Js::DelayLoadWindowsGlobalization* globLibrary = threadContext->GetWindowsGlobalizationLibrary();
                 HRESULT hr = globalizationAdapter->EnsureDataTextObjectsInitialized(globLibrary);
-                // Failed to load windows.globalization.dll or jsintl.dll. No unicodeStatics support
-                // in that case.
+                // Failed to load windows.globalization.dll or jsintl.dll. No unicodeStatics support in that case.
                 if (SUCCEEDED(hr))
                 {
                     auto winGlobCharApi = globalizationAdapter->GetUnicodeStatics();
                     if (winGlobCharApi != nullptr)
                     {
                         return true;
                     }
+#if INTL_ICU || INTL_WINGLOB // don't assert in _no_icu builds (where there is no i18n library, by design)
+                    else
+                    {
+                        // did not find winGlobCharApi
+                        Js::Throw::FatalInternalGlobalizationError();
+                    }
+                }
+                else
+                {
+                    // failed to initialize Windows Globalization
+                    Js::Throw::FatalInternalGlobalizationError();
+#endif
                 }
 
-                return false;
+#if (INTL_ICU || INTL_WINGLOB) && !defined(DBG)
+                return false; // in debug builds, this is unreachable code
+#endif
             }, false);
         }