Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsRunScriptUtf8 missing #2006

Closed
d4nnyk opened this issue Nov 14, 2016 · 4 comments
Closed

JsRunScriptUtf8 missing #2006

d4nnyk opened this issue Nov 14, 2016 · 4 comments

Comments

@d4nnyk
Copy link

d4nnyk commented Nov 14, 2016

JsRunScriptUtf8 is missing from the Master branch, which is used in all of the samples for Linux. I guess previously there was a Linux branch and currently it's not there.

Could you please add this? or change the example program to use current exposed API?

@liminzhu
Copy link
Collaborator

liminzhu commented Nov 14, 2016

// fyi @obastemur

Hi @d4nnyk. The utf8 APIs were experimental, and we've replaced them with something we believe is better for cross-platform apps #1830. Do you have a dependency on the old APIs? In a nutshell, the way to use new string APIs is 1) converting native strings (const char/uint8_t/uint16_t) to JsValueRef (a JavaScript var in JSRT), 2) then call new APIs that consumes JsValueRef instead of native string. For example, JsRun (corresponding to windows-only JsRunScript and obsolete JsRunScriptUtf8).

We will have the docs/samples updated shortly.

@d4nnyk
Copy link
Author

d4nnyk commented Nov 14, 2016

Thanks! I had to go through some of the "test" code to find "JsRun" and I have ported the old code.
It will be great if you can change the sample code :)

@obastemur
Copy link
Collaborator

We track this issue at microsoft/Chakra-Samples#47 and the PR for new samples microsoft/Chakra-Samples#48

@obastemur
Copy link
Collaborator

@d4nnyk Thanks for reporting anyways 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants