-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FunctionComp.defaultProps
is going to be deprecated in React 18.3.0
#7057
Labels
Comments
isBatak
added
the
needs triage
Issues and pull requests that need triage attention
label
Nov 29, 2022
TimKolberger
added
PR welcome 😇
and removed
needs triage
Issues and pull requests that need triage attention
labels
Nov 30, 2022
PR submmited. This is my first contribution, please let know if I missed anything. |
I've also submitted a PR which sufficiently solves the problem for all components: #7068 The PR submitted by @AlexKvazos only solved the problem in one component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This issue is based on this Discord report
The error that happens when using Portal with Next.js 13.0.5
The root of the problem:
chakra-ui/packages/components/portal/src/portal.tsx
Line 178 in 4d5501b
Links to React PR and ESLint change:
facebook/react#25699
jsx-eslint/eslint-plugin-react#2396
Other components might also be affected.
Problem Statement/Justification
This will make Chakra UI more aligned with React 18.3.0
Proposed Solution or API
Change:
Into:
The goal isn't to remove
defaultProps
, but to change how they're defined on function components.Alternatives
No response
Additional Information
No response
The text was updated successfully, but these errors were encountered: