Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't match cursorSave and cursorRestore #36

Closed
SamVerschueren opened this issue Apr 28, 2021 · 3 comments · Fixed by #45
Closed

Can't match cursorSave and cursorRestore #36

SamVerschueren opened this issue Apr 28, 2021 · 3 comments · Fixed by #45

Comments

@SamVerschueren
Copy link
Contributor

Today I was working with the regex and noticed that cursorSave and cursorRestore don't get stripped with strip-ansi.

I didn't check the other use cases yet, but wanted to make sure first that it is correct what I assume here.

It is the case, happy to send a PR.

@Qix-
Copy link
Member

Qix- commented Apr 28, 2021

Yep good catch, these seem to be missing looking at the pattern again. A PR would be awesome :)

@SamVerschueren
Copy link
Contributor Author

I'm wondering, would it make sense to add ansi-escapes as dev dependency and then call ansi-escapes in the tests so we know for sure that it strips everything that ansi-escapes support?

@Qix-
Copy link
Member

Qix- commented Apr 28, 2021

@SamVerschueren I think that makes a lot of sense. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants