Skip to content

Commit f180678

Browse files
committed
Security: Set ch_sid cookie to 'secure' when using HTTPS - refs BT#21289
1 parent 925e49f commit f180678

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

main/inc/lib/chamilo_session.class.php

+3-1
Original file line numberDiff line numberDiff line change
@@ -86,14 +86,16 @@ public static function start($already_installed = true)
8686
//ini_set('session.cookie_secure', 1);
8787
//session ID in the cookie is only readable by the server
8888
ini_set('session.cookie_httponly', 1);
89+
if (api_is_https()) {
90+
ini_set('session.cookie_secure', 1);
91+
}
8992

9093
if (api_get_configuration_value('security_session_cookie_samesite_none')) {
9194
if (PHP_VERSION_ID < 70300) {
9295
$sessionCookieParams = session_get_cookie_params();
9396
session_set_cookie_params($sessionCookieParams['lifetime'], '/; samesite=None',
9497
$sessionCookieParams['domain'], true, $sessionCookieParams['httponly']);
9598
} else {
96-
ini_set('session.cookie_secure', 1);
9799
ini_set('session.cookie_samesite', 'None');
98100
}
99101
}

0 commit comments

Comments
 (0)