Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Awesome method overlap #1

Open
wasREDACTED opened this issue Oct 4, 2020 · 0 comments
Open

Font Awesome method overlap #1

wasREDACTED opened this issue Oct 4, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@wasREDACTED
Copy link
Collaborator

Summary: pulling two version of FA via two separate methods, may redux complexity/page loads by pulling current FA via one method.

v5.0.9 - as JS in scripts.html

<script src="https://use.fontawesome.com/releases/v5.0.9/js/all.js"></script>

v5.7.1 - as CSS in head/custom.html

<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.7.1/css/all.css" integrity="sha384-fnmOCqbTlWIlj8LyTjo7mOUStjsKC4pOpQbqyi7RrhN7udi9RwhKkMHpvLbHG9Sr" crossorigin="anonymous">

(and semi-related there's a weird bug with your custom head snippets, they are being duplicated in footer as well)

Current method: minimal-mistakes pulls fontawesome via css in _includes/head.html. They're using jsdelivr, but you could substitute fontawesome as the source here. PR Discussion
https://github.com/mmistakes/minimal-mistakes/blob/d6444412c63aea5e47241ef536509fb1bfef4830/_includes/head.html#L16

Example: Font Awesome updated with a /latest/ reference to save on version specific flags.

<link rel="stylesheet" href="https://kit-free.fontawesome.com/releases/latest/css/free.min.css">
<!-- or -->
<script type="text/javascript" href="https://kit-free.fontawesome.com/releases/latest/js/free.min.js">
@wasREDACTED wasREDACTED added the enhancement New feature or request label Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant