Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major version released on patch changes #381

Open
vicary opened this issue Jul 18, 2024 · 1 comment
Open

Major version released on patch changes #381

vicary opened this issue Jul 18, 2024 · 1 comment

Comments

@vicary
Copy link

vicary commented Jul 18, 2024

We are relying on the Version Packages auto PR to publish to NPM.

But we recently found that minor and patch changes are triggering major upgrades,

  1. The behaviour is correct up to this PR.
    Version Packages gqty-dev/gqty#1841
  2. Incorrect major pump on @gqty/logger, @gqty/react and @gqty/subscriptions
    Version Packages gqty-dev/gqty#1845
  3. This PR seems correct, albeit pumping on an incorrect major.
    Version Packages gqty-dev/gqty#1859
  4. Again, incorrect major pump on @gqty/logger, @gqty/react and @gqty/subscriptions
    Version Packages gqty-dev/gqty#1903

Am I doing anything wrong with my changeset files?

@Pewtro
Copy link

Pewtro commented Aug 9, 2024

I also pretty frequently run into this issue, for example: Pewtro/blizzard-api#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants