-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
que in rails should enable eager_loading #184
Comments
Just FYI @joevandyk @chanks recommend this is closed, as time has passed and Sidekiq no longer does this AFAICT for rails 5+. (see below for rationale). Sidekiq FAQ now
Sidekiq code nowThere's an explicit pathway in the code for "# Rails 5+ && development mode, use Reloader".
So I think this force eager-loading is only for pre v5 (maybe the intention was for 4.2.0+, but the code says 5+). |
Cleaning up old issues. Yeah, I'm going to close this since it's old, people aren't really complaining about it and I don't think we should add any more Rails-specific logic unless it's really necessary (it's very difficult to test well). |
from sidekiq faq;
https://github.com/mperham/sidekiq/blob/efadb9ac69f57d07df51645939a01ee05b87d905/lib/sidekiq/cli.rb#L238-L242
The text was updated successfully, but these errors were encountered: