feat(Popover): allow focus upon popover panel open #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #1782 +/- ##
=======================================
Coverage 92.35% 92.35%
=======================================
Files 147 147
Lines 2656 2656
Branches 711 711
=======================================
Hits 2453 2453
Misses 187 187
Partials 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
size-limit report 📦
|
| <Popover.Button as={Button} data-testid="popover-trigger-button"> | ||
| Open Popover | ||
| </Popover.Button> | ||
| <Popover.Content data-testid="popover-content" focus> |
There was a problem hiding this comment.
I may be missing something, why does the content need focus set?
There was a problem hiding this comment.
focus enables the behavior where it will focus on the element once the popover is generated
jeremiah-clothier
approved these changes
Oct 12, 2023
- expose the `focus` option from HeadlessUI's .Panel API - add test with `play` to trigger the behavio for a snapshot
booc0mtaco
force-pushed
the
aholloway/EFI-1418
branch
from
7d59ebe
to
3576c58
Compare
Merged
booc0mtaco
added a commit
that referenced
this pull request
Oct 13, 2023
## [13.6.0](v13.5.0...v13.6.0) (2023-10-13) ### Features * **Menu:** allow href and onClick to co-exist on a menu item ([#1779](#1779)) ([971f189](971f189)) * **Popover:** allow focus upon popover panel open ([#1782](#1782)) ([76ddbc6](76ddbc6)) ### Bug Fixes * **Accordion:** handle multi-line text in headers ([#1783](#1783)) ([0b3c3e6](0b3c3e6)) * **Select:** expose render prop and default value param.s ([#1781](#1781)) ([f21e2b6](f21e2b6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Merge in the props from HeadlessUI for the panel, to support
focus. This allows consumers to send focus to a particular piece of content within the content container.onFocusalso allows for hooking into the internals in case there are some arguments to trigger upon focus.Test Plan:
edu-stackortrajectas a sanity check if changes affect build or deploy, or are breaking, such as token changes, widely used component updates, hooks changes, and major dependency upgrades.