feat(Select): add support for required in overline #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- model it to work and look like what exists for InputField - add tests and new snapshots
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1855 +/- ##
==========================================
+ Coverage 92.61% 92.62% +0.01%
==========================================
Files 148 148
Lines 2856 2862 +6
Branches 776 780 +4
==========================================
+ Hits 2645 2651 +6
Misses 195 195
Partials 16 16 ☔ View full report in Codecov by Sentry. |
|
|
ahuth
approved these changes
Feb 23, 2024
|
Note: this has no specific handling for there being too much text for both the label AND the required text. This is intentional for now; designs should have considerations for both mobile and desktop layouts, and design components provide an early opportunity to give visual guidance on inappropriate text lengths. Fallbacks (max viewable text length) and safeguards can be added where needed. |
Merged
booc0mtaco
added a commit
that referenced
this pull request
Mar 4, 2024
## [13.12.0](v13.11.0...v13.12.0) (2024-03-04) [Storybook](https://61313967cde49b003ae2a860-telsscxlak.chromatic.com/?path=/docs/getting-started--docs) ### Features * export ClickableStyleProps ([#1860](#1860)) ([0d1b49e](0d1b49e)) * **Select:** add support for required in overline ([#1855](#1855)) ([6e44566](6e44566)) ### Bug Fixes * lodash tree shaking ([#1852](#1852)) ([f55f9cb](f55f9cb)) * **Select:** add max height for Select.Options ([#1858](#1858)) ([24ed8bc](24ed8bc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: