feat(Modal): add height property to modal API #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
booc0mtaco
force-pushed
the
aholloway/EDS-1377
branch
from
73042c0
to
8efbe5d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2011 +/- ##
=======================================
Coverage 97.58% 97.59%
=======================================
Files 109 109
Lines 2572 2578 +6
Branches 645 647 +2
=======================================
+ Hits 2510 2516 +6
Misses 60 60
Partials 2 2 ☔ View full report in Codecov by Sentry. |
booc0mtaco
force-pushed
the
aholloway/EDS-1377
branch
from
8efbe5d
to
c97aa84
Compare
booc0mtaco
force-pushed
the
aholloway/EDS-1377
branch
from
c97aa84
to
721d322
Compare
ericraymond
approved these changes
Jul 10, 2024
booc0mtaco
force-pushed
the
aholloway/EDS-1377
branch
from
835a6ae
to
721d322
Compare
- allow fixed (default), auto, and max - add stories with doc.s - change export for ModalContent to fix storybook - update snapshots
booc0mtaco
force-pushed
the
aholloway/EDS-1377
branch
from
721d322
to
4339ae8
Compare
booc0mtaco
added a commit
that referenced
this pull request
Jul 15, 2024
## [15.1.0](v15.0.1...v15.1.0) (2024-07-15) [Storybook](https://61313967cde49b003ae2a860-qztphlqyid.chromatic.com/) ### Features * add runtime warning/errors to components ([#2007](#2007)) ([661130b](661130b)) * **InputField:** add show/hide button for password field type ([#2006](#2006)) ([52d9ca0](52d9ca0)) * **Modal:** add height property to modal API ([#2011](#2011)) ([8d0c68f](8d0c68f)) ### Bug Fixes * **Icon:** update pencil icon to latest design ([#2016](#2016)) ([cb8d1a7](cb8d1a7)) * **Link:** apply font weight to standalone sizes ([#2015](#2015)) ([2e47271](2e47271)) * **Select:** expose generic types to allow by to pass type checks ([#2008](#2008)) ([421c91b](421c91b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping
Modalto 2.1 with the following functionality:Test Plan: