fix(Link): apply font weight to standalone sizes #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix handling of size so it isn't applied where it can't be used - add assert for using size with context=inline - update tests and snapshots
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2015 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 109 109
Lines 2578 2579 +1
Branches 647 647
=======================================
+ Hits 2511 2512 +1
Misses 65 65
Partials 2 2 ☔ View full report in Codecov by Sentry. |
jgao-czi
approved these changes
Jul 12, 2024
| } | ||
|
|
||
| &.link--size-xs { | ||
| font: var(--eds-theme-typography-body-xs); | ||
| font-weight: 500; |
There was a problem hiding this comment.
Oh just so 500 is the expected font size for Links?
There was a problem hiding this comment.
500 is the weight for each link size. We have to add them here b/c font: will try to set it to 400 which is what we saw. later this year when we revisit the typography tokens, we won't need this anymore (will be transparent to you all when that happens)
timzchang
approved these changes
Jul 12, 2024
|
Thanks @timzchang @jgao-czi :) |
Merged
booc0mtaco
added a commit
that referenced
this pull request
Jul 15, 2024
## [15.1.0](v15.0.1...v15.1.0) (2024-07-15) [Storybook](https://61313967cde49b003ae2a860-qztphlqyid.chromatic.com/) ### Features * add runtime warning/errors to components ([#2007](#2007)) ([661130b](661130b)) * **InputField:** add show/hide button for password field type ([#2006](#2006)) ([52d9ca0](52d9ca0)) * **Modal:** add height property to modal API ([#2011](#2011)) ([8d0c68f](8d0c68f)) ### Bug Fixes * **Icon:** update pencil icon to latest design ([#2016](#2016)) ([cb8d1a7](cb8d1a7)) * **Link:** apply font weight to standalone sizes ([#2015](#2015)) ([2e47271](2e47271)) * **Select:** expose generic types to allow by to pass type checks ([#2008](#2008)) ([421c91b](421c91b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan: