Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): update typography tokens to match design #2019

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

booc0mtaco
Copy link
Contributor

  • create missing button small token and use in component
  • update snapshots

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Created and used an alpha publish
  • Manually tested my changes, and here are the details:

@booc0mtaco booc0mtaco requested a review from a team July 16, 2024 16:16
Copy link

github-actions bot commented Jul 16, 2024

size-limit report 📦

Path Size
components 88.78 KB (0%)
styles 27.74 KB (-0.06% 🔽)

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40%. Comparing base (d76d5bb) to head (aa0e1a1).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2019   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files         109      109           
  Lines        2579     2579           
  Branches      647      647           
=======================================
  Hits         2512     2512           
  Misses         65       65           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- create missing button small token and use in component
- truncate some button labels in stories
- update snapshots
@booc0mtaco booc0mtaco requested a review from jgao-czi July 17, 2024 20:29
@booc0mtaco
Copy link
Contributor Author

@jgao-czi re-pushed the review, which upgraded the status :)

@booc0mtaco booc0mtaco merged commit 3b94114 into next Jul 17, 2024
10 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1371 branch July 17, 2024 20:31
@booc0mtaco booc0mtaco mentioned this pull request Jul 25, 2024
booc0mtaco added a commit that referenced this pull request Jul 26, 2024
## [15.2.0](v15.1.0...v15.2.0) (2024-07-25)

[Storybook](https://61313967cde49b003ae2a860-bksjqddurj.chromatic.com/)

### Features

* **Fieldset:** update styles to support new 2.0 components ([#2023](#2023)) ([e542b32](e542b32))


### Bug Fixes

* **Button:** update typography tokens to match design ([#2019](#2019)) ([3b94114](3b94114))
* **InputField:** align text content with inputWithin spacing ([#2020](#2020)) ([e87767b](e87767b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants