fix(Menu): remove style overrides to Menu.Button #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove style overrides left from 1.0 component - update snapshots and re-run tests
booc0mtaco
force-pushed
the
aholloway/EFI-1936
branch
from
8a7f756
to
98b3144
Compare
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2029 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 109 109
Lines 2608 2608
Branches 664 664
=======================================
Hits 2541 2541
Misses 65 65
Partials 2 2 ☔ View full report in Codecov by Sentry. |
ahuth
approved these changes
Aug 7, 2024
Merged
booc0mtaco
added a commit
that referenced
this pull request
Aug 12, 2024
### [15.2.1](v15.2.0...v15.2.1) (2024-08-09) [Storybook](https://61313967cde49b003ae2a860-wzpwvsymfs.chromatic.com/) ### Bug Fixes * **Button:** update button padding to match design ([#2027](#2027)) ([15644d3](15644d3)) * **Checkbox:** specify a font size for the checked glyph ([#2030](#2030)) ([6777316](6777316)) * **Menu:** remove style overrides to Menu.Button ([#2029](#2029)) ([2ad7b4c](2ad7b4c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Test Plan: