feat(tokens): update visited tokens #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add text-utility-interactive-primary-visited - add text-utility-interactive-secondary-visited - add icon-utility-interactive-primary-visited - add icon-utility-interactive-secondary-visited - mark text-utility-interactive-visited as deprecated - mark icon-utility-interactive-visited as deprecated - change text-utility-inverse-interactive-visited from purple-350 to white - update usages of old tokens to use the new tokens
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2034 +/- ##
=======================================
Coverage 97.42% 97.43%
=======================================
Files 109 109
Lines 2605 2609 +4
Branches 664 664
=======================================
+ Hits 2538 2542 +4
Misses 65 65
Partials 2 2 ☔ View full report in Codecov by Sentry. |
booc0mtaco
commented
Aug 14, 2024
| @@ -114,7 +114,7 @@ | |||
| } | |||
|
|
|||
| .link:visited { | |||
| color: var(--eds-theme-color-text-utility-interactive-visited); | |||
| color: var(--eds-theme-color-text-utility-interactive-primary-visited); | |||
There was a problem hiding this comment.
update usages of old tokens to use the new tokens
Comment on lines
+1703
to
+1705
| "visited": { | ||
| "value": "{eds.theme.color.text.utility.interactive.primary.visited}", | ||
| "group": "color" |
There was a problem hiding this comment.
add icon-utility-interactive-primary-visited
Comment on lines
+1721
to
+1723
| "visited": { | ||
| "value": "{eds.theme.color.text.utility.interactive.secondary.visited}", | ||
| "group": "color" |
There was a problem hiding this comment.
add icon-utility-interactive-secondary-visited
Comment on lines
1726
to
+1729
| "visited": { | ||
| "value": "{eds.theme.color.text.utility.interactive.visited}", | ||
| "group": "color" | ||
| "group": "color", | ||
| "comment": "@deprecated This should not be used in code or design. It will be removed in a future version of EDS." |
There was a problem hiding this comment.
mark icon-utility-interactive-visited as deprecated
Comment on lines
+2046
to
+2047
| "visited": { | ||
| "value": "{eds.color.blue.850}" |
There was a problem hiding this comment.
add text-utility-interactive-primary-visited
Comment on lines
+2060
to
+2061
| "visited": { | ||
| "value": "{eds.color.blue.550}" |
There was a problem hiding this comment.
add text-utility-interactive-secondary-visited
Comment on lines
+2065
to
+2066
| "value": "{eds.color.purple.550}", | ||
| "comment": "@deprecated This token is deprecated. Please use eds-theme-color-border-brand-primary-default instead" |
There was a problem hiding this comment.
mark text-utility-interactive-visited as deprecated
| @@ -2111,7 +2127,7 @@ | |||
| }, | |||
| "interactive": { | |||
| "visited": { | |||
| "value": "{eds.color.purple.350}" | |||
| "value": "rgb(var(--eds-color-white) / 1)" | |||
There was a problem hiding this comment.
change text-utility-inverse-interactive-visited from purple-350 to white
ahuth
approved these changes
Aug 14, 2024
Merged
booc0mtaco
added a commit
that referenced
this pull request
Aug 23, 2024
## [15.3.0](v15.2.1...v15.3.0) (2024-08-23) [Storybook](https://61313967cde49b003ae2a860-vuzmfnjuoj.chromatic.com/) Figma Components Library: 🟢 No breaking changes - EDS-toastNotification: - deleted the dissmissType property - Added Toast Pattern documentation to handle multiple toasts - EDS-popover: added EDS-popover 2.0 component ### Features * **config:** add transition durations for tailwind ([#2036](#2036)) ([aed0f09](aed0f09)) * **Popover:** update theming to 2.0 ([#2031](#2031)) ([c5ab351](c5ab351)) * **tokens:** add in additional table tokens ([#2035](#2035)) ([a698a5b](a698a5b)) * **tokens:** update visited tokens ([#2034](#2034)) ([df84c87](df84c87)) ### Bug Fixes * **Card:** add spacing between eyebrow and title ([#2040](#2040)) ([d6ee15d](d6ee15d)) * **Link:** handle inverse variant for standalone links ([#2042](#2042)) ([351d7fd](351d7fd)) * **Popover:** update component version number ([#2038](#2038)) ([9940d76](9940d76))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan: