feat(DataTable): introduce 1.0 component #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
booc0mtaco
force-pushed
the
aholloway/EDS-1209
branch
2 times, most recently
from
bfb25c4
to
eec0119
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2050 +/- ##
==========================================
- Coverage 97.44% 97.05% -0.39%
==========================================
Files 109 111 +2
Lines 2618 2751 +133
Branches 668 727 +59
==========================================
+ Hits 2551 2670 +119
- Misses 65 78 +13
- Partials 2 3 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
booc0mtaco
force-pushed
the
aholloway/EDS-1209
branch
7 times, most recently
from
d95fe1a
to
4f6ed48
Compare
booc0mtaco
force-pushed
the
aholloway/EDS-1209
branch
6 times, most recently
from
4bf0653
to
e95db61
Compare
- new component for complex data-based table content - add in the documentation for props - add in types, layouts, and test - add in snapshots - make use of newly-added tokens
- use tanstack as basis for table implementation - add in relevant stories for styles - add in snapshots for tests
- add stories to show column separators - add stories for sticky column/row treatments
booc0mtaco
force-pushed
the
aholloway/EDS-1209
branch
2 times, most recently
from
a601be8
to
066cdaa
Compare
- add implementation detail stories - update snapshots and tests
booc0mtaco
force-pushed
the
aholloway/EDS-1209
branch
from
066cdaa
to
c903ece
Compare
booc0mtaco
force-pushed
the
aholloway/EDS-1209
branch
from
4c839c6
to
9a8985e
Compare
ahuth
approved these changes
Sep 26, 2024
|
@ahuth thanks ! 🫡 |
Merged
booc0mtaco
added a commit
that referenced
this pull request
Sep 27, 2024
## [15.4.0](v15.3.1...v15.4.0) (2024-09-26) [Storybook](https://61313967cde49b003ae2a860-sdpxmjxjai.chromatic.com/) ### Features * **Button:** support for not-allowed cursor when disabled ([#2052](#2052)) ([46cb9f6](46cb9f6)) * **DataTable:** introduce 1.0 component ([#2050](#2050)) ([ffd0e82](ffd0e82)), closes [#2055](#2055) ### Bug Fixes * **Button:** apply external styles when disabled ([#2060](#2060)) ([e762d8b](e762d8b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc.s
https://61313967cde49b003ae2a860-kjsjrdvscz.chromatic.com/?path=/docs/components-datatable--docs
Test Plan: