feat(Button): support for not-allowed cursor when disabled #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2052 +/- ##
=======================================
Coverage 97.43% 97.44%
=======================================
Files 109 109
Lines 2615 2618 +3
Branches 665 668 +3
=======================================
+ Hits 2548 2551 +3
Misses 65 65
Partials 2 2 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
booc0mtaco
commented
Aug 30, 2024
| @@ -263,23 +263,21 @@ | |||
| * Disabled | |||
| */ | |||
| .button--disabled { | |||
| pointer-events: none; | |||
There was a problem hiding this comment.
We disable all the pointer events for these buttons to make them truly disabled (and this avoids having to add styles to override the :hover, :active and other pseudo-selectors
| } | ||
| } | ||
|
|
||
| .button__disabled { |
There was a problem hiding this comment.
this is to style a container when disabled. because pointer-events is also how the cursor gets styled, we cannot just add cursor: not-allow
ahuth
approved these changes
Aug 31, 2024
Merged
booc0mtaco
added a commit
that referenced
this pull request
Sep 27, 2024
## [15.4.0](v15.3.1...v15.4.0) (2024-09-26) [Storybook](https://61313967cde49b003ae2a860-sdpxmjxjai.chromatic.com/) ### Features * **Button:** support for not-allowed cursor when disabled ([#2052](#2052)) ([46cb9f6](46cb9f6)) * **DataTable:** introduce 1.0 component ([#2050](#2050)) ([ffd0e82](ffd0e82)), closes [#2055](#2055) ### Bug Fixes * **Button:** apply external styles when disabled ([#2060](#2060)) ([e762d8b](e762d8b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan: