fix(Button): apply external styles when disabled #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- apply passed in class names to disabled wrapper, not the actual button
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2060 +/- ##
=======================================
Coverage 97.44% 97.44%
=======================================
Files 109 109
Lines 2618 2619 +1
Branches 668 669 +1
=======================================
+ Hits 2551 2552 +1
Misses 65 65
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ahuth
approved these changes
Sep 26, 2024
Merged
booc0mtaco
added a commit
that referenced
this pull request
Sep 27, 2024
## [15.4.0](v15.3.1...v15.4.0) (2024-09-26) [Storybook](https://61313967cde49b003ae2a860-sdpxmjxjai.chromatic.com/) ### Features * **Button:** support for not-allowed cursor when disabled ([#2052](#2052)) ([46cb9f6](46cb9f6)) * **DataTable:** introduce 1.0 component ([#2050](#2050)) ([ffd0e82](ffd0e82)), closes [#2055](#2055) ### Bug Fixes * **Button:** apply external styles when disabled ([#2060](#2060)) ([e762d8b](e762d8b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that, when
Buttonis used, any utility classes applied to the button get applied to the wrapper (e.g., positioning, etc.)Test Plan: