Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-export HeadlessUI's Transition component #2069

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented Oct 9, 2024

Provide the transition component from HeadlessUI to consumers, since there is no bound UI or design for this helper component, and would otherwise take time to implement separately.

Test Plan:

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:

@booc0mtaco booc0mtaco requested a review from a team October 9, 2024 22:00
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.06%. Comparing base (ff7dd65) to head (b71cc88).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2069   +/-   ##
=======================================
  Coverage   97.06%   97.06%           
=======================================
  Files         111      111           
  Lines        2756     2757    +1     
  Branches      732      735    +3     
=======================================
+ Hits         2675     2676    +1     
  Misses         78       78           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 9, 2024

size-limit report 📦

Path Size
components 92.51 KB (+0.06% 🔺)
styles 28.73 KB (0%)

@booc0mtaco booc0mtaco merged commit a4a5fc8 into next Oct 10, 2024
12 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1410 branch October 10, 2024 16:22
@booc0mtaco booc0mtaco mentioned this pull request Oct 18, 2024
booc0mtaco added a commit that referenced this pull request Oct 21, 2024
## [15.5.0](v15.4.1...v15.5.0) (2024-10-18)

[Storybook](https://61313967cde49b003ae2a860-gtyxxzokxd.chromatic.com/)

### Features

* **DataTable:** add support for table row statuses ([#2073](#2073)) ([c109f52](c109f52))
* re-export HeadlessUI's Transition component ([#2069](#2069)) ([a4a5fc8](a4a5fc8))


### Bug Fixes

* **DataTable:** fix cell size and border in FF ([#2072](#2072)) ([7ffbd56](7ffbd56))
* **Select:** remove label checks from component ([#2068](#2068)) ([8ede09d](8ede09d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants