-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Tag): update to 2.0 styles #2087
Conversation
- use new render color tokens - update layout - update tests and snapshots
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2087 +/- ##
==========================================
+ Coverage 97.02% 97.06% +0.04%
==========================================
Files 111 111
Lines 2786 2792 +6
Branches 753 755 +2
==========================================
+ Hits 2703 2710 +7
+ Misses 79 78 -1
Partials 4 4 ☔ View full report in Codecov by Sentry. |
@@ -45,6 +44,7 @@ | |||
|
|||
/** | |||
* Color variants. | |||
* TODO(next-major): remove these status colors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these TODO tracked as tickets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not currently, tho its not a bad idea to create one and add the detail of "delete all the deprecated things"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a tracker to the backlog
* | ||
* **Default is `"neutral"`**. | ||
*/ | ||
variant?: Variant; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we allow for breaking API contract with major version bump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, we do. Here, I moved variant
to another part of Props
for consistency (and to alphabetize better). those TODO(next-major) comments are for when we do the next major, likely in the new year.
This one is backwards-compatible with some warnings (those assertEDSUsage
log messages)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK got it, thanks
## [15.7.0](v15.6.0...v15.7.0) (2024-11-18) [Storybook](https://61313967cde49b003ae2a860-cpbnunloqv.chromatic.com/) ### Features * **InputChip:** add 1.0 component ([#2097](#2097)) ([2f68041](2f68041)) * **Tag:** update to 2.0 styles ([#2087](#2087)) ([a344222](a344222)) ### Bug Fixes * **deps:** update dependency ts-morph to v24 ([#2102](#2102)) ([350c72b](350c72b))
Test Plan: