Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tag): update to 2.0 styles #2087

Merged
merged 1 commit into from
Nov 14, 2024
Merged

feat(Tag): update to 2.0 styles #2087

merged 1 commit into from
Nov 14, 2024

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented Nov 7, 2024

  • use new render color tokens
  • update layout
  • update tests and snapshots

Test Plan:

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:

- use new render color tokens
- update layout
- update tests and snapshots
@booc0mtaco booc0mtaco requested a review from a team November 7, 2024 23:16
Copy link

github-actions bot commented Nov 7, 2024

size-limit report 📦

Path Size
components 93.05 KB (+0.24% 🔺)
styles 29.17 KB (+0.49% 🔺)

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.06%. Comparing base (46a4b7f) to head (e0b9d6c).
Report is 9 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2087      +/-   ##
==========================================
+ Coverage   97.02%   97.06%   +0.04%     
==========================================
  Files         111      111              
  Lines        2786     2792       +6     
  Branches      753      755       +2     
==========================================
+ Hits         2703     2710       +7     
+ Misses         79       78       -1     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -45,6 +44,7 @@

/**
* Color variants.
* TODO(next-major): remove these status colors

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these TODO tracked as tickets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not currently, tho its not a bad idea to create one and add the detail of "delete all the deprecated things"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a tracker to the backlog

*
* **Default is `"neutral"`**.
*/
variant?: Variant;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we allow for breaking API contract with major version bump?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we do. Here, I moved variant to another part of Props for consistency (and to alphabetize better). those TODO(next-major) comments are for when we do the next major, likely in the new year.

This one is backwards-compatible with some warnings (those assertEDSUsage log messages)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK got it, thanks

@booc0mtaco booc0mtaco merged commit a344222 into next Nov 14, 2024
12 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1420 branch November 14, 2024 22:19
@booc0mtaco booc0mtaco mentioned this pull request Nov 18, 2024
booc0mtaco added a commit that referenced this pull request Nov 19, 2024
## [15.7.0](v15.6.0...v15.7.0) (2024-11-18)

[Storybook](https://61313967cde49b003ae2a860-cpbnunloqv.chromatic.com/)

### Features

* **InputChip:** add 1.0 component ([#2097](#2097)) ([2f68041](2f68041))
* **Tag:** update to 2.0 styles ([#2087](#2087)) ([a344222](a344222))


### Bug Fixes

* **deps:** update dependency ts-morph to v24 ([#2102](#2102)) ([350c72b](350c72b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants