Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_db_session should not start a new engine for each request #100

Open
ninabernick opened this issue Aug 21, 2024 · 0 comments
Open

get_db_session should not start a new engine for each request #100

ninabernick opened this issue Aug 21, 2024 · 0 comments

Comments

@ninabernick
Copy link
Collaborator

In the SQLAlchemy docs, it states that an engine is typically created once and held for the lifetime of an app. We should probably be initializing it on startup, not creating a new one on each request. We may even be calling this once for each level of a GQL request (to investigate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant