Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeattr --compress has 1024 character output limit #62

Closed
gmatthew190 opened this issue Aug 16, 2024 · 2 comments · Fixed by #63
Closed

nodeattr --compress has 1024 character output limit #62

gmatthew190 opened this issue Aug 16, 2024 · 2 comments · Fixed by #63
Assignees

Comments

@gmatthew190
Copy link

HOSTLIST_BUFLEN in nodeattr.c is used in _hash_hostrange such that the output size from nodeattr -f <file> --compress can only be <= 1024 characters:

nodeattr -f <(echo "thing0769,thing0773,thing0777,thing0778,thing0783,thing0785,thing0788,thing0789,thing0791,thing0793,thing0794,thing0801,thing0802,thing0803,thing0804,thing0805,thing0806,thing0807,thing0809,thing0817,thing0820,thing0821,thing0822,thing0825,thing0826,thing0827,thing0831,thing0833,thing0836,thing0838,thing0841,thing0842,thing0846,thing0847,thing0849,thing0852,thing0854,thing0857,thing0858,thing0862,thing0865,thing0866,thing0868,thing0870,thing0871,thing0873,thing0874,thing0886,thing0901,thing0906,thing0909,thing0911,thing0912,thing0917,thing0919,thing0921,thing0925,thing0926,thing0927,thing0928,thing0934,thing0935,thing0939,thing0942,thing0944,thing0948,thing0950,thing0952,thing0954,thing0955,thing0964,thing0967,thing0971,thing0973,thing0983,thing0984,thing0989,thing0990,thing0991,thing0996,thing0997,thing1001,thing1012,thing1014,thing1015,thing1017,thing1018,thing1021,thing1164,thing1165,thing1178,thing1179,thing1195,thing1197,thing1211,thing1226,thing1242,thing1245,thing1258,thing1261,thing1274,thing1277,thing1281,thing1282,thing1284,thing1286,thing1287,thing1288,thing1298,thing1300,thing1302,thing1304,thing1313,thing1314,thing1315,thing1316,thing1319,thing1320,thing1329,thing1334,thing1335,thing1345,thing1348,thing1350,thing1351,thing1361,thing1363,thing1364,thing1366,thing1367,thing1368,thing1377,thing1382,thing1383,thing1393,thing1394,thing1398,thing1399,thing1417,thing1418,thing1421,thing1433,thing1435,thing1436,thing1437,thing1438,thing1439,thing1449,thing1450,thing1454,thing1465,thing1466,thing1468,thing1471,thing1481,thing1483,thing1484,thing1485,thing1487,thing1497,thing1499,thing1500,thing1501,thing1513,thing1514,thing1515,thing1517,thing1518,thing1520,thing1529,thing1530,thing1531,thing1532,thing1533,thing1537,thing1543,thing1544,thing1545,thing1548,thing1553,thing1555,thing1558,thing1560,thing1561,thing1564,thing1572,thing1575,thing1576,thing1581,thing1582,thing1590,thing1592,thing1593,thing1599,thing1603,thing1608,thing1612,thing1615,thing1619,thing1620,thing1623,thing1624,thing1625,thing1629,thing1631,thing1635,thing1636,thing1640,thing1641,thing1644,thing1645,thing1647,thing1651,thing1652,thing1654,thing1661,thing1672,thing1673,thing1675,thing1678,thing1679,thing1686,thing1688,thing1689,thing1694,thing1695,thing1702") --compress
thing[0769,0773,0777-0778,0783,0785,0788-0789,0791,0793-0794,0801-0807,0809,0817,0820-0822,0825-0827,0831,0833,0836,0838,0841-0842,0846-0847,0849,0852,0854,0857-0858,0862,0865-0866,0868,0870-0871,0873-0874,0886,0901,0906,0909,0911-0912,0917,0919,0921,0925-0928,0934-0935,0939,0942,0944,0948,0950,0952,0954-0955,0964,0967,0971,0973,0983-0984,0989-0991,0996-0997,1001,1012,1014-1015,1017-1018,1021,1164-1165,1178-1179,1195,1197,1211,1226,1242,1245,1258,1261,1274,1277,1281-1282,1284,1286-1288,1298,1300,1302,1304,1313-1316,1319-1320,1329,1334-1335,1345,1348,1350-1351,1361,1363-1364,1366-1368,1377,1382-1383,1393-1394,1398-1399,1417-1418,1421,1433,1435-1439,1449-1450,1454,1465-1466,1468,1471,1481,1483-1485,1487,1497,1499-1501,1513-1515,1517-1518,1520,1529-1533,1537,1543-1545,1548,1553,1555,1558,1560-1561,1564,1572,1575-1576,1581-1582,1590,1592-1593,1599,1603,1608,1612,1615,1619-1620,1623-1625,1629,1631,1635-1636,1640-1641,1644-1645,1647,1651-1652,1654,1661,1672-1673,1675,1678-1679,1686,1688-1689,1694-1695,1702]

nodeattr -f <(echo "thing0769,thing0773,thing0777,thing0778,thing0783,thing0785,thing0788,thing0789,thing0791,thing0793,thing0794,thing0801,thing0802,thing0803,thing0804,thing0805,thing0806,thing0807,thing0809,thing0817,thing0820,thing0821,thing0822,thing0825,thing0826,thing0827,thing0831,thing0833,thing0836,thing0838,thing0841,thing0842,thing0846,thing0847,thing0849,thing0852,thing0854,thing0857,thing0858,thing0862,thing0865,thing0866,thing0868,thing0870,thing0871,thing0873,thing0874,thing0886,thing0901,thing0906,thing0909,thing0911,thing0912,thing0917,thing0919,thing0921,thing0925,thing0926,thing0927,thing0928,thing0934,thing0935,thing0939,thing0942,thing0944,thing0948,thing0950,thing0952,thing0954,thing0955,thing0964,thing0967,thing0971,thing0973,thing0983,thing0984,thing0989,thing0990,thing0991,thing0996,thing0997,thing1001,thing1012,thing1014,thing1015,thing1017,thing1018,thing1021,thing1164,thing1165,thing1178,thing1179,thing1195,thing1197,thing1211,thing1226,thing1242,thing1245,thing1258,thing1261,thing1274,thing1277,thing1281,thing1282,thing1284,thing1286,thing1287,thing1288,thing1298,thing1300,thing1302,thing1304,thing1313,thing1314,thing1315,thing1316,thing1319,thing1320,thing1329,thing1334,thing1335,thing1345,thing1348,thing1350,thing1351,thing1361,thing1363,thing1364,thing1366,thing1367,thing1368,thing1377,thing1382,thing1383,thing1393,thing1394,thing1398,thing1399,thing1417,thing1418,thing1421,thing1433,thing1435,thing1436,thing1437,thing1438,thing1439,thing1449,thing1450,thing1454,thing1465,thing1466,thing1468,thing1471,thing1481,thing1483,thing1484,thing1485,thing1487,thing1497,thing1499,thing1500,thing1501,thing1513,thing1514,thing1515,thing1517,thing1518,thing1520,thing1529,thing1530,thing1531,thing1532,thing1533,thing1537,thing1543,thing1544,thing1545,thing1548,thing1553,thing1555,thing1558,thing1560,thing1561,thing1564,thing1572,thing1575,thing1576,thing1581,thing1582,thing1590,thing1592,thing1593,thing1599,thing1603,thing1608,thing1612,thing1615,thing1619,thing1620,thing1623,thing1624,thing1625,thing1629,thing1631,thing1635,thing1636,thing1640,thing1641,thing1644,thing1645,thing1647,thing1651,thing1652,thing1654,thing1661,thing1672,thing1673,thing1675,thing1678,thing1679,thing1686,thing1688,thing1689,thing1694,thing1695,thing1702") --compress | wc
      1       1    1018

Here I add "onetoomany" to the list used above:

nodeattr -f <(echo "thing0769,thing0773,thing0777,thing0778,thing0783,thing0785,thing0788,thing0789,thing0791,thing0793,thing0794,thing0801,thing0802,thing0803,thing0804,thing0805,thing0806,thing0807,thing0809,thing0817,thing0820,thing0821,thing0822,thing0825,thing0826,thing0827,thing0831,thing0833,thing0836,thing0838,thing0841,thing0842,thing0846,thing0847,thing0849,thing0852,thing0854,thing0857,thing0858,thing0862,thing0865,thing0866,thing0868,thing0870,thing0871,thing0873,thing0874,thing0886,thing0901,thing0906,thing0909,thing0911,thing0912,thing0917,thing0919,thing0921,thing0925,thing0926,thing0927,thing0928,thing0934,thing0935,thing0939,thing0942,thing0944,thing0948,thing0950,thing0952,thing0954,thing0955,thing0964,thing0967,thing0971,thing0973,thing0983,thing0984,thing0989,thing0990,thing0991,thing0996,thing0997,thing1001,thing1012,thing1014,thing1015,thing1017,thing1018,thing1021,thing1164,thing1165,thing1178,thing1179,thing1195,thing1197,thing1211,thing1226,thing1242,thing1245,thing1258,thing1261,thing1274,thing1277,thing1281,thing1282,thing1284,thing1286,thing1287,thing1288,thing1298,thing1300,thing1302,thing1304,thing1313,thing1314,thing1315,thing1316,thing1319,thing1320,thing1329,thing1334,thing1335,thing1345,thing1348,thing1350,thing1351,thing1361,thing1363,thing1364,thing1366,thing1367,thing1368,thing1377,thing1382,thing1383,thing1393,thing1394,thing1398,thing1399,thing1417,thing1418,thing1421,thing1433,thing1435,thing1436,thing1437,thing1438,thing1439,thing1449,thing1450,thing1454,thing1465,thing1466,thing1468,thing1471,thing1481,thing1483,thing1484,thing1485,thing1487,thing1497,thing1499,thing1500,thing1501,thing1513,thing1514,thing1515,thing1517,thing1518,thing1520,thing1529,thing1530,thing1531,thing1532,thing1533,thing1537,thing1543,thing1544,thing1545,thing1548,thing1553,thing1555,thing1558,thing1560,thing1561,thing1564,thing1572,thing1575,thing1576,thing1581,thing1582,thing1590,thing1592,thing1593,thing1599,thing1603,thing1608,thing1612,thing1615,thing1619,thing1620,thing1623,thing1624,thing1625,thing1629,thing1631,thing1635,thing1636,thing1640,thing1641,thing1644,thing1645,thing1647,thing1651,thing1652,thing1654,thing1661,thing1672,thing1673,thing1675,thing1678,thing1679,thing1686,thing1688,thing1689,thing1694,thing1695,thing1702,onetoomany") --compress
hostlist_ranged_string: Success
@chu11
Copy link
Member

chu11 commented Aug 16, 2024

Hi, we hit a similar situation with chaos/powerman#193, so I think we're just starting to hit large enough clusters to exceed this buffer size. We can up the buffer size.

@gmatthew190
Copy link
Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants