Improve tmbundle support

[bradcray]

This issue is meant to track Chapel syntax that isn't highlighted properly by tmbundle which, as I understand it, is what GitHub uses for syntax coloring.

• It seems that ref is not highlighted as being a keyword, for example in:

var y = 10;
ref x = y;

[lydia-duncan]

I think GitHub doesn't use tmbundle anymore, I never saw the "in", "throws", etc. changes turn up even though I updated the repo and it looked like they were referencing the chapel-lang one instead of the bholt one.

[ronawho]

Related to #5908. And I agree with lydia, I think github moved to something else. Linguist or something like that?

[ben-albrecht]

@ronawho && @lydia-duncan -- linguist still uses Chapel's tmbundle, as shown here (ctrl-f chapel)

[cassella]

Looking at linguist's collection of tmbundle grammars,

https://github.com/github/linguist/tree/master/vendor/grammars

it looks like each grammar is imported as a submodule, including
chapel-tmbundle. Submodules link by a specific commit -- I think
it'll take a PR against linguist to change which chapel-tmbundle
commit linguist should use.

[lydia-duncan]

From the README on Linguist:

If you experience an issue with the syntax-highlighting on GitHub, please report the issue to the upstream grammar repository, not here. Grammars are updated every time we build the Linguist gem and so upstream bug fixes are automatically incorporated as they are fixed.

That seems to imply to me that they should get fixes automatically.

[lydia-duncan]

That's not to say that @cassella's interpretation is incorrect, just that maybe they should know about it and update their documentation if it is.

[bradcray]

That seems to imply to me that they should get fixes automatically.

Is there any way to determine when Linguist was last rebuilt and which version GitHub is using -- essentially see whether it's been updated since our last edits to tmbundle?

[ben-albrecht]

Is there any way to determine when Linguist was last rebuilt and which version GitHub is using -- essentially see whether it's been updated since our last edits to tmbundle?

They update every release, and their last release was on May 25th:

https://github.com/github/linguist/releases

Unfortunately, our most recent tmbundle changes went in on June 16th, so we won't see these changes until the next linguist release.

I assume GitHub is using the latest version, but couldn't find that info anywhere.

Here's the latest PR that updated submodules:

https://github.com/github/linguist/pull/3642/files

[lydia-duncan]

That would explain it, my changes were in June.

[cassella]

Progress! linguist 5.1.0 includes the latest chapel-tmbundle,

https://github.com/github/linguist/pull/3725/files

That picks up the exception handling keywords, but chapel-tmbundle
doesn't include "ref" yet.

proc tically(in solvent, out rageous, ref lective, var nish, inout terspace) throws {
     try { ptophan(); }
     catch n: ReleaseError {
     	 throw n;
     }
}

[victor-ludorum]

@bradcray Hello , I have worked on "Incorrect Syntax Highlighting For Escaped Character '"' #6899 " . So, I think I can work on this . Please suggest me only "ref" keyword is not there or any other keywords are too not present in the chapel tmbundle which should be added .

[bradcray]

Hi @victor-ludorum : I'm not aware of keywords other than 'ref' that are missing, though I wouldn't be surprised if there are some. I'm not sure what people would consider the most definitive list of Chapel keywords these days. Anybody else on this thread have a suggestion?

[victor-ludorum]

@bradcray I have figured out some missing keyword from the Chapel tmbundle from the link
These are inout, out , ref, subdomain , sync and opaque . Suggest if anymore keyword are missing

[bradcray]

I believe those should be highlighted, thanks Victor!

[victor-ludorum]

@bradcray Okay sir I will submit a PR resolving this issue .