-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive caused by brackets #14
Comments
Thanks. This is fixed in |
Seems when the bracketed case have no space it will still fail: |
Hmm...I can't reproduce that case. First of all, I had to disable |
I am using https://github.com/golangci/golangci-lint to call durationcheck, maybe something is wrong on their side.. |
I still can't reproduce with either golangcl-lint (1.40.2) or the standalone linter. Weird! 🤷🏽 |
I just realized golangcl-lint (1.40.1) is still on 0.6 🤦. Installing the latest resolved the issue. Thank you for checking 🙏. |
time.Duration(attempts) * time.Millisecond
is fine, buttime.Duration((attempts)) * time.Millisecond
causes a false positive.(The real scenario was doing some maths inside the time.Duration():
time.Duration((attempts-1)*2)*time.Millisecond)
.)The text was updated successfully, but these errors were encountered: