Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive when multiplying with int type struct field #7

Closed
ajpetersons opened this issue Feb 17, 2021 · 1 comment · Fixed by #8
Closed

False positive when multiplying with int type struct field #7

ajpetersons opened this issue Feb 17, 2021 · 1 comment · Fixed by #8

Comments

@ajpetersons
Copy link

Struct fields are not taken into account when assessing duration multiplication. Consider a struct that has int field. When this field is multiplied by a valid duration value, linter throws an error (to multiply with duration, the field needs to be converted to time.Duration first).

See this example:

package main

import (
	"time"
)

type s struct {
	d int
}

func main() {
	ss := s{10}
	_ = time.Duration(ss.d) * time.Second
}
@edigaryev
Copy link

This is also documented in the time package (see "To convert an integer number of units to a Duration, multiply:"):

seconds := 10
fmt.Print(time.Duration(seconds)*time.Second) // prints 10s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants