Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beeps on success as well as error #19

Closed
svileng opened this issue Feb 9, 2015 · 4 comments
Closed

Beeps on success as well as error #19

svileng opened this issue Feb 9, 2015 · 4 comments

Comments

@svileng
Copy link

svileng commented Feb 9, 2015

According to documentation, it's supposed to do a console beep when there are errors, but for me it happens on every run. Using 0.4.3 and MacOSX 10.9.5. Any ideas?

@charliedowler
Copy link
Collaborator

Hmm, thats odd.

It's working fine for me, can you show me the config you're using?

Can't see anything immediately in the code that could cause it to beep when successful.

Cheers,
Charlie

@svileng
Copy link
Author

svileng commented Feb 12, 2015

@charliedowler

The whole app is here: https://github.com/svileng/react-es6-browserify-flowtype

I found that when I do a fresh run, if I have no errors, it doesn't beep; however, once I start getting errors, the beep never stops, even if I fix everything and it's all green.

Thanks for having a look!

@charliedowler
Copy link
Collaborator

Fixed!

Thanks for the issue @svileng, this affects everyone using gulp-flowtype in a watch task.

Will publish later tonight.

@svileng
Copy link
Author

svileng commented Feb 13, 2015

Cheers, thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants