Since version 0.10 gum choose --no-limit selection of one element by Enter does not work

[WoozyMasta]

Since version 0.10 gum choose --no-limit selection of one element by Enter does not work

To Reproduce
in versions 0.7-0.9 when pressing Enter one element at a time it is selected, in version 0.10 nothing will be selected

0.7-0.9

> printf '%s\n' Foo Bar Baz | gum choose --no-limit; echo $?
Foo
0

0.10

> printf '%s\n' Foo Bar Baz | gum choose --no-limit; echo $?
0

Desktop:
Linux 5.15.0-50-generic x86_64 Ubuntu 22.04.2 LTS (Jammy Jellyfish)

[ajs256]

Can confirm on macOS 13.3.1 with the built-in terminal.

[ajs256]

It seems to also happen with gum filter, on version 0.9.0 as well.

[MikaelFangel]

The selection behaviour was changed by e6de774 referring to #140 (:

[ajs256]

@MikaelFangel Okay, but how do you actually select multiple items now?

[MikaelFangel]

@ajs256 You select multiple by pressing space.

[WoozyMasta]

@MikaelFangel
But this is not obvious behavior, if I need only one element, why should I additionally select it before use it?

Before 0.10, it seems to me there was a more logical behavior

[MikaelFangel]

@WoozyMasta imo the problem with just selecting the highlighted one was that it didn't seem obvious that it would select it if I pressed enter. But I also hear you on the issue with the additional button press and that it is a breaking change.

However both functionalities are wanted and I'm not in a position to make the choice about this (:

[bdrnglm]

In my opinion, the current behavior is more "logical," as only the selected items are returned. If the user presses enter without selecting any item, the command should return none to signal that no items have been selected. Otherwise, it would be difficult to determine if any items were selected or not.

[WoozyMasta]

The old behavior seems more obvious

It now returns an exit status of 0 and an empty response when I hover over the second element and press enter. The element was selected by the arrows, I just don't need to mark it because I only want one element.

Naturally, if I need to select several elements, I must select each one separately.

UX looks exactly like this, and this is exactly the problem that we are facing in the current version. It might be worth making a popup here to let you know that nothing is selected, but this is a much more complex implementation than just returning logic to select one item under the cursor.

I see solutions like this:

• in case of empty choice return exit code not equal to 0
• return the logic as it was, do not make breaking changes
• return the logic as it was, make the new logic an option through the launch argument (I like this option)
• give feedback to the user that he did not select anything

[bdrnglm]

I agree with you. Maybe we should keep it as is to prevent breaking scripts using older version, and make the actual behavior an option at launch for those who want it.

[alexn-s]

@MikaelFangel kinda stupid question but when i try to select multiple (with space) it does not select the item but adds a space to the search query.

currently i cant select multiple

am i missing something?

example

"apple", "banana " | gum filter --no-limit

gum version: 0.10.0
env: windows powershell

[MikaelFangel]

@alexn-s actually this is not a stupid question. I seem to have trouble selecting multiple using the example provided by the README as well.

Edit:
Got it to function properly. Must have pressed it wrong when I tried 😅

[alexn-s]

huh... thanks for letting me know

[maaslalani]

@alexn-s In your example you would need to separate the options by newlines:

echo "apple\nbanana" | gum filter --no-limit

or:

echo "apple" >> choices.txt
echo "banana" >> choices.txt
cat choices.txt | gum filter --no-limit

To select, you can press ctrl+space or tab

[alexn-s]

@maaslalani

comma works fine in powerhell. echo with newline does not work
tab works. did not try that

ctrl+space does not work

thanks for the help

[Justinzobel]

I just came across this from another issue to figure out how to select multiple items. If this information could be added to the README in the no-limit section it would improve the user experience.

[caarlos0]

fixed on main!

thanks