Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document minimum React Native version supported #154

Closed
chrisbobbe opened this issue May 1, 2020 · 5 comments
Closed

Document minimum React Native version supported #154

chrisbobbe opened this issue May 1, 2020 · 5 comments
Labels
📚 Documentation Improvements or additions to documentation React Native Compatibility This issue or pull request is related to React Native Compatibility

Comments

@chrisbobbe
Copy link

chrisbobbe commented May 1, 2020

Thanks for this! 🙂 The list of bugs in React Native core's polyfill in the README is quite startling, and I've reproduced facebook/react-native#25717, so far.


A file in react-native-url-polyfill, which was added in 1.0.0, the initial release, depends on a file in React Native, which was added in v0.61.0.

On RN v0.59.10, which I'm using, I get this error from Metro:

error: bundling failed: Error: Unable to resolve module `react-native/Libraries/Blob/NativeBlobModule` from `/Users/chrisbobbe/dev/zulip-mobile/node_modules/react-native-url-polyfill/js/URL.js`: Module `react-native/Libraries/Blob/NativeBlobModule` does not exist in the Haste module map

There may be other factors preventing react-native-url-polyfill from working prior to RN v0.61.0, or indeed it might continue to not work until after that (maybe even v0.62?).

It would be nice to have a note, maybe in the install instructions in the README, on what the earliest supported React Native version is, for the latest release of react-native-url-polyfill, and perhaps mention in the notes for each release if that number changes.

Hopefully this data point will help with that. 🙂

@charpeni
Copy link
Owner

charpeni commented May 1, 2020

Thanks for this detailed issue, I appreciate the feedback!

I’ll make sure to mention it clearly in the README, but also specifying supported versions of React Native in peerDependencies so we can have a warning on installation too.

What you mentioned regarding upcoming releases is also important to prevent breaking changes. I’ll make sure to keep the tests up-to-date with it.

I didn’t had a lot of time for this recently, but I should be able to find some soon.

Thanks again for filling this!

@chrisbobbe
Copy link
Author

Great, thanks so much! Stay safe, with COVID-19, and all.

@charpeni
Copy link
Owner

charpeni commented Jun 1, 2020

I'm currently working on adding support for older version (0.59) and also making sure to test a larger band of React Native versions.

@charpeni
Copy link
Owner

charpeni commented Jun 9, 2020

@chrisbobbe react-native-url-polyfill@1.2.0-rc.0 is now available with backward support for RN 0.60 & 0.59, and probably more!

Let me know how it goes for you so I can release it officially.

@chrisbobbe
Copy link
Author

Confirmed that 1.2.0-rc.0 worked for me on react-native v0.59.10 and on react-native v0.60.6! Thank you!

@charpeni charpeni added 📚 Documentation Improvements or additions to documentation React Native Compatibility This issue or pull request is related to React Native Compatibility labels Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 Documentation Improvements or additions to documentation React Native Compatibility This issue or pull request is related to React Native Compatibility
Projects
None yet
Development

No branches or pull requests

2 participants