-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document minimum React Native version supported #154
Comments
Thanks for this detailed issue, I appreciate the feedback! I’ll make sure to mention it clearly in the README, but also specifying supported versions of React Native in What you mentioned regarding upcoming releases is also important to prevent breaking changes. I’ll make sure to keep the tests up-to-date with it. I didn’t had a lot of time for this recently, but I should be able to find some soon. Thanks again for filling this! |
Great, thanks so much! Stay safe, with COVID-19, and all. |
I'm currently working on adding support for older version (0.59) and also making sure to test a larger band of React Native versions. |
@chrisbobbe Let me know how it goes for you so I can release it officially. |
Confirmed that 1.2.0-rc.0 worked for me on |
Thanks for this! 🙂 The list of bugs in React Native core's polyfill in the README is quite startling, and I've reproduced facebook/react-native#25717, so far.
A file in
react-native-url-polyfill
, which was added in 1.0.0, the initial release, depends on a file in React Native, which was added in v0.61.0.On RN v0.59.10, which I'm using, I get this error from Metro:
There may be other factors preventing
react-native-url-polyfill
from working prior to RN v0.61.0, or indeed it might continue to not work until after that (maybe even v0.62?).It would be nice to have a note, maybe in the install instructions in the README, on what the earliest supported React Native version is, for the latest release of
react-native-url-polyfill
, and perhaps mention in the notes for each release if that number changes.Hopefully this data point will help with that. 🙂
The text was updated successfully, but these errors were encountered: