-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mobx dev tools #10
Comments
Thanks for the report and fix! Could you do I made the change you suggested but haven't got the dev tools installed at the moment to figure out the views. |
The disappearing names are really confusing... Reactions are reported here: spyReportStart({
name: this.name,
type: "reaction"
}) The devtools listen to the event here: case 'reaction':
// object, fn
change.objectName = observableName(mobx, change.object);
break; Where does Similarly computed values are reported here: spyReport({
object: this.scope,
type: "compute",
name: this.name
}) Devtools expect the case 'compute':
// object, target, fn
change.objectName = observableName(mobx, change.object);
change.targetName = getNameForThis(mobx, change.target);
break; |
Works fine. |
Currently everything is unnamed inside the mox dev tools.
A patch like (sorry, npm forking is still annoyingly complicated in conjunction with typescript and just patching over the lib a lot easier to setup)
Will show names for actions at least:
There still are a lot of undefined things though. I tried also naming the views and getters but it didn't result in any noticeable change. Do you maybe have some idea, where these async reactions etc. could be named/lose their name.
The text was updated successfully, but these errors were encountered: