Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Deleted At Column in the database and back fill user data #530

Open
3 tasks
eleanorreem opened this issue Jul 18, 2024 · 7 comments
Open
3 tasks

Create Deleted At Column in the database and back fill user data #530

eleanorreem opened this issue Jul 18, 2024 · 7 comments
Assignees
@srodif
Labels
complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days javascript Pull requests that update Javascript code maintenance Maintenance / chore work priority: soon Should be prioritized soon. stale This issue or PR is inactive. state: approved Ready to go. Not blocked or pending.
Milestone
02. Roadmaps

Comments

@eleanorreem
Copy link
Contributor

Overview

When a user requests to be deleted, we soft delete them and hash their personal details. If we want to find a list of dates users were deleted, we can guess when the user was deleted by seeing if the user is set as user.active=false and take the date in the updatedAt column. However, we would prefer for this data to have its own column. We want to also add a nullable column to the user called "deletedAt" so we can have the date of when the user was deleted for monitoring purposes. We also want to backfill the data

Action Items

  • Create the deletedAt column on the user table
  • Write a migration which sets the uesr.deletedAt column to the date of user.updatedAt where the user.active is set to false
  • Create a PR and tag @eleanorreem and @annarhughes as reviewers
@eleanorreem eleanorreem added complexity: advanced Time needed to do this ticket will be large e.g. 2-3+ days complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days priority: soon Should be prioritized soon. state: approved Ready to go. Not blocked or pending. maintenance Maintenance / chore work javascript Pull requests that update Javascript code and removed complexity: advanced Time needed to do this ticket will be large e.g. 2-3+ days labels Jul 18, 2024
@eleanorreem eleanorreem mentioned this issue Jul 18, 2024
Open
3 tasks
@kyleecodes kyleecodes added this to the 02. Roadmaps milestone Jul 18, 2024
@srodif
Copy link
Contributor

srodif commented Jul 20, 2024

Hello! Could you assign this issue to me? Thanks in advance!

@github-actions GitHub Actions
Copy link

Thank you @eleanorreem you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request shortly ✨

Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about Chayn here and explore our projects. 🌸

@eleanorreem eleanorreem removed their assignment Jul 22, 2024
@github-actions GitHub Actions
Copy link

Thank you @eleanorreem you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request shortly ✨

Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about Chayn here and explore our projects. 🌸

@eleanorreem
Copy link
Contributor Author

@srodif accidentally assigned myself. Ignore the bot - you are assigned!

@srodif srodif mentioned this issue Jul 30, 2024
Merged
@srodif
Copy link
Contributor

srodif commented Aug 4, 2024

Hello @eleanorreem! I have created a pull request for this issue. Should I add something else?

@kyleecodes kyleecodes reopened this Aug 5, 2024
@github-actions github-actions bot added the stale This issue or PR is inactive. label Sep 9, 2024
@srodif
Copy link
Contributor

srodif commented Sep 10, 2024

Just to note that I continue to work on this, for the second action item.

@kyleecodes kyleecodes removed the stale This issue or PR is inactive. label Sep 17, 2024
@eleanorreem
Copy link
Contributor Author

@srodif I didn't see your comment that you were still working on it - apologies! Can you make a separate PR for the migration work? Thank you!

@github-actions github-actions bot added the stale This issue or PR is inactive. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srodif srodif

Labels
complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days javascript Pull requests that update Javascript code maintenance Maintenance / chore work priority: soon Should be prioritized soon. stale This issue or PR is inactive. state: approved Ready to go. Not blocked or pending.
Projects
None yet
Milestone
02. Roadmaps
Development

No branches or pull requests
3 participants
@eleanorreem @kyleecodes @srodif