Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't merge draft PRs #404

Closed
mohsen1 opened this issue May 23, 2020 · 3 comments
Closed

Don't merge draft PRs #404

mohsen1 opened this issue May 23, 2020 · 3 comments

Comments

@mohsen1
Copy link

mohsen1 commented May 23, 2020

vercel/next.js#13193

I was surprised to see this PR was merged. Work wasn't completed actually

@mohsen1 mohsen1 added the bug Something isn't working label May 23, 2020
@chdsbd
Copy link
Owner

chdsbd commented May 23, 2020

It appears merge.require_automerge_label is disabled on that repository, so as long as the pull request meets all GitHub Branch Protection requirements it will be merged.

https://github.com/zeit/next.js/blob/canary/.github/.kodiak.toml#L6

@chdsbd
Copy link
Owner

chdsbd commented May 23, 2020

Enabling merge.require_automerge_label would make it so Kodiak only merges pull requests with the automerge label, but if this can't be changed, there's a couple workarounds.

One workaround is to move the pull request into a "draft" state. GitHub does not allow draft pull requests to be merged.

Another option is to put "WIP:" in the title, which will prevent Kodiak from merging the pull request based on merge.blacklist_title_regex.

@chdsbd chdsbd added help-request and removed bug Something isn't working labels May 23, 2020
@mohsen1
Copy link
Author

mohsen1 commented May 24, 2020

Thank you for the links! I must've clicked "Ready for review" by accident. GitHub is not showing when that happened in timeline so I'm not sure if I did it or someone else. Turns out GitHub doesn't allow merging draft PRs from the UI. if there is a bug in GitHub API that allows to do that then maybe this is an actual issue, otherwise I think this is a false alarm

Thanks! 💞

@mohsen1 mohsen1 closed this as completed May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants