Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a better naming for chePlugin spec reference #13

Closed
l0rd opened this issue Feb 5, 2020 · 2 comments
Closed

Find a better naming for chePlugin spec reference #13

l0rd opened this issue Feb 5, 2020 · 2 comments
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Feb 5, 2020

Currently the following syntax are used to reference the spec in a che-plugin registry or in a yaml file published on the internet respectively:

components:
  - chePlugin:
      registry:
        id: redhat/vscode-yaml/latest
        registryUrl: "external-registry-url"
  - chePlugin:
      url: https://gist.../meta.yaml

That may be confusing. We should find a better name.

@l0rd l0rd mentioned this issue Feb 5, 2020
28 tasks
@davidfestal
Copy link
Collaborator

In the PR #29, that introduces changes agreed on in issue #25, I included the following proposal which would also be useful to reference a parent devfile inside a devfile registry:

components:
  - chePlugin:
      registryEntry:
        id: redhat/vscode-yaml/latest
        baseUrl: "external-registry-url"
  - chePlugin:
      url: https://gist.../meta.yaml

To be fully consistent with the parent case, we could use uri instead of url when pointing directly to a plugin meta.yaml

@davidfestal
Copy link
Collaborator

Implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants