Skip to content

Commit

Permalink
Merge pull request #225 from check-run-reporter/node-20
Browse files Browse the repository at this point in the history
node 20
  • Loading branch information
ianwremmel authored Jan 25, 2024
2 parents 846dea5 + 9cc9fda commit ff021c9
Show file tree
Hide file tree
Showing 6 changed files with 10,150 additions and 6,304 deletions.
79 changes: 37 additions & 42 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
@@ -1,43 +1,41 @@
on: push
name: Validate
jobs:
# TODO fix the fixup action to handle branch names other than master
# fixup:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v2.3.4
# with:
# fetch-depth: 0
# - uses: ianwremmel/prevent-fixup-commits@v1.0.2
fixup:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: ianwremmel/prevent-fixup-commits@v1.0.8

# TODO fix the nopush action to handle branch names other than master
# nopush:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v2.3.4
# with:
# fetch-depth: 0
# - uses: ianwremmel/prevent-nopush-commits@v1.0.3
nopush:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: ianwremmel/prevent-nopush-commits@v1.0.8

build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '20'
cache: 'npm'
- run: npm ci
- run: npm run build
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: dist
path: dist
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: action-dist
path: integrations/action/dist
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: buildkite-bin
path: integrations/check-run-reporter-buildkite-plugin/bin
Expand All @@ -47,18 +45,17 @@ jobs:
- build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: actions/setup-node@v2
- uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '20'
cache: 'npm'
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v4
with:
name: action-dist
path: integrations/action/dist
- run: npm i -g npm@7
- run: npm ci
- run: npm run lint
env:
Expand Down Expand Up @@ -87,18 +84,17 @@ jobs:
nodeCount: [2]
nodeIndex: [0, 1]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '20'
cache: 'npm'
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v4
with:
name: action-dist
path: integrations/action/dist
- run: npm i -g npm@7
- run: npm ci
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v4
with:
name: dist
path: dist
Expand All @@ -121,7 +117,7 @@ jobs:
lint-integrations-buildkite:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: 'docker://buildkite/plugin-linter'
with:
args: --id check-run-reporter/check-run-reporter --path /github/workspace/integrations/check-run-reporter-buildkite-plugin
Expand All @@ -131,10 +127,10 @@ jobs:
- build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
submodules: recursive
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v4
with:
name: buildkite-bin
path: integrations/check-run-reporter-buildkite-plugin/bin
Expand All @@ -145,20 +141,19 @@ jobs:
release:
needs:
- build
# TODO - fixup
- fixup
- lint
- lint-integrations-buildkite
# TODO - nopush
- nopush
- test
- test-integrations-buildkite
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '20'
cache: 'npm'
- run: npm i -g npm@7
- run: npm ci
# Remember: Can't use artifacts here because we need to build during
# semantic-release to figure out the version number. Also, artifacts mess
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
node_modules
reports
.idea
12 changes: 9 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,20 @@ $(DIST_TYPES_FILES) &: $(SRC_FILES)
dist/ncc/index.js: $(SRC_FILES)
> $(NPX) ncc build ./src/cli.ts --source-map --out dist/ncc

# Vercel has abandoned pkg, so we're stuck with bundling node18 likely until
# node22 goes lts with native support for single executable applications
dist/pkg/crr-$(VERSION)-linux: dist/ncc/index.js
> $(NPX) pkg . --target linux --output $@
> $(NPX) pkg . --target node18-linux --output $@

# Vercel has abandoned pkg, so we're stuck with bundling node18 likely until
# node22 goes lts with native support for single executable applications
dist/pkg/crr-$(VERSION)-macos: dist/ncc/index.js
> $(NPX) pkg . --target macos --output $@
> $(NPX) pkg . --target node18-macos --output $@

# Vercel has abandoned pkg, so we're stuck with bundling node18 likely until
# node22 goes lts with native support for single executable applications
dist/pkg/crr-$(VERSION)-windows.exe: dist/ncc/index.js
> $(NPX) pkg . --target windows --output $@
> $(NPX) pkg . --target node18-windows --output $@

README.md:
> $(NPX) markdown-toc -i --bullets='-' --maxdepth=3 README.md
Expand Down
Loading

0 comments on commit ff021c9

Please sign in to comment.