Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user claim configurable #183

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Conversation

zhouzhuojie
Copy link
Collaborator

Sometimes the user claim may not be sub, so here just make it easy to configure via ENV.

@zhouzhuojie zhouzhuojie force-pushed the zz/make-user-claim-configurable branch from 00eb8fe to b575392 Compare October 26, 2018 00:04
@codecov-io
Copy link

codecov-io commented Oct 26, 2018

Codecov Report

Merging #183 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files          25       25           
  Lines        1409     1409           
=======================================
  Hits         1280     1280           
  Misses         96       96           
  Partials       33       33
Impacted Files Coverage Δ
pkg/handler/jwt.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51ab24b...b575392. Read the comment docs.

@zhouzhuojie
Copy link
Collaborator Author

related to #121

@zhouzhuojie zhouzhuojie merged commit f4c18c0 into master Oct 26, 2018
@zhouzhuojie zhouzhuojie deleted the zz/make-user-claim-configurable branch October 26, 2018 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants