Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder middlewares and add test for must parse kafka version #191

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

zhouzhuojie
Copy link
Collaborator

Reorder the middleware so that other stats logging can catch recovery middleware.

  • Move recovery middleware closer to the application code
  • Use logrus for recovery middleware logging, so that it can catch recovery error in sentry
  • Add tests for mustParseKafkaVersion

@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #191 into master will decrease coverage by 0.06%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   85.79%   85.72%   -0.07%     
==========================================
  Files          23       23              
  Lines        1316     1324       +8     
==========================================
+ Hits         1129     1135       +6     
- Misses        131      134       +3     
+ Partials       56       55       -1
Impacted Files Coverage Δ
pkg/handler/data_recorder_kafka.go 82.29% <100%> (+2.08%) ⬆️
pkg/config/middleware.go 96.07% <80.95%> (-3.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865b4af...a00cf1f. Read the comment docs.

@zhouzhuojie zhouzhuojie force-pushed the zz/move-middleware-order branch from 4ef7f5d to a00cf1f Compare November 14, 2018 05:49
@zhouzhuojie zhouzhuojie changed the title Add test for must parse kafka version Reorder middlewares and add test for must parse kafka version Nov 14, 2018
Copy link

@ziru ziru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhouzhuojie zhouzhuojie merged commit 26e524d into master Nov 14, 2018
@zhouzhuojie zhouzhuojie deleted the zz/move-middleware-order branch November 14, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants