Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yarn and upgrade to vue-cli 3 #265

Merged
merged 3 commits into from
May 31, 2019
Merged

Remove yarn and upgrade to vue-cli 3 #265

merged 3 commits into from
May 31, 2019

Conversation

zhouzhuojie
Copy link
Collaborator

@zhouzhuojie zhouzhuojie commented May 31, 2019

Description

  • Remove yarn and use npm instead
  • Move to vue-cli v3
    • Refactor how we set env
    • Refactor VUE_APP_FLAGR_UI_POSSIBLE_ENTITY_TYPES in the UI. We still keep the same Dockerfile build-args FLAGR_UI_POSSIBLE_ENTITY_TYPES
  • Bump axios
  • Refactor how to build the Dockfile
    • Remove Dockerfile-CI and in favor of official docker images (golang:1.12 and node:10)
    • Refactor circleci tests

Motivation and Context

  • To keep up the current vue-cli version
  • To leverage official docker image instead of flagr-ci image
  • Migrate from yarn to npm

How Has This Been Tested?

Tested locally. Also tested with FLAGR_WEB_PREFIX.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

Codecov Report

Merging #265 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files          26       26           
  Lines        1530     1530           
=======================================
  Hits         1251     1251           
  Misses        210      210           
  Partials       69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d30c35...8e7c8de. Read the comment docs.

@zhouzhuojie zhouzhuojie merged commit f702cd3 into master May 31, 2019
@zhouzhuojie zhouzhuojie deleted the zz/remove-yarn branch May 31, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants