Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Dynamic Configuration section #280

Merged

Conversation

kgeorgiou
Copy link
Contributor

Update Dynamic Configuration section to match the variant attachment format updates introduced in #259

Description

Motivation and Context

Documentation.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zhouzhuojie
Copy link
Collaborator

Thanks for the PR. LGTM. I fixed the integration tests in #281. If you can rebase, everything will be good.

Update Dynamic Configuration section to match the variant attachment format updates introduced in openflagr#259.
@kgeorgiou kgeorgiou force-pushed the docs/update-dynamic-configuration branch from 89794ae to 83479a1 Compare August 8, 2019 03:09
@codecov-io
Copy link

Codecov Report

Merging #280 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files          26       26           
  Lines        1530     1530           
=======================================
  Hits         1251     1251           
  Misses        210      210           
  Partials       69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a82375...83479a1. Read the comment docs.

@kgeorgiou
Copy link
Contributor Author

Done :)

Copy link
Collaborator

@zhouzhuojie zhouzhuojie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@zhouzhuojie zhouzhuojie merged commit 0d7481b into openflagr:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants