Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alpine 3.10 with glibc and bump remote docker in ciecleci #281

Merged
merged 2 commits into from
Aug 6, 2019

Conversation

zhouzhuojie
Copy link
Collaborator

@zhouzhuojie zhouzhuojie commented Aug 5, 2019

libc6-compat looks not working correctly in the circleci environment. fnctl64 not found was thrown in the new integration tests and alpine 3.6 images.

Wanna test if bumping the alpine to 3.10 with glibc and the remote docker engine can solve the error of https://circleci.com/gh/checkr/flagr/907

Specifically, https://hub.docker.com/r/frolvlad/alpine-glibc and https://github.com/frol/docker-alpine-glibc is a popular alpine glibc base image to get started.

@zhouzhuojie zhouzhuojie changed the title Bump remote docker in ciecleci Use alpine 3.10 with glibc and bump remote docker in ciecleci Aug 6, 2019
@codecov-io
Copy link

Codecov Report

Merging #281 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files          26       26           
  Lines        1530     1530           
=======================================
  Hits         1251     1251           
  Misses        210      210           
  Partials       69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ef72d...9cae90f. Read the comment docs.

@zhouzhuojie zhouzhuojie requested a review from a team August 6, 2019 00:23
FROM alpine:3.6
RUN apk add --no-cache libc6-compat ca-certificates curl
FROM frolvlad/alpine-glibc:alpine-3.10
RUN apk add --no-cache curl
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ca-certificates is already included in frolvlad/alpine-glibc

@zhouzhuojie
Copy link
Collaborator Author

Related to
#270
#105

Copy link

@gusk gusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@marceloboeira marceloboeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@zhouzhuojie zhouzhuojie merged commit 9a82375 into master Aug 6, 2019
@zhouzhuojie zhouzhuojie deleted the zz/bump-remote-docker-circleci branch August 6, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants