-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use alpine 3.10 with glibc and bump remote docker in ciecleci #281
Conversation
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=======================================
Coverage 81.76% 81.76%
=======================================
Files 26 26
Lines 1530 1530
=======================================
Hits 1251 1251
Misses 210 210
Partials 69 69 Continue to review full report at Codecov.
|
FROM alpine:3.6 | ||
RUN apk add --no-cache libc6-compat ca-certificates curl | ||
FROM frolvlad/alpine-glibc:alpine-3.10 | ||
RUN apk add --no-cache curl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ca-certificates
is already included in frolvlad/alpine-glibc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
libc6-compat
looks not working correctly in the circleci environment.fnctl64 not found
was thrown in the new integration tests and alpine 3.6 images.Wanna test if bumping the alpine to 3.10 with glibc and the remote docker engine can solve the error of https://circleci.com/gh/checkr/flagr/907
Specifically, https://hub.docker.com/r/frolvlad/alpine-glibc and https://github.com/frol/docker-alpine-glibc is a popular alpine glibc base image to get started.