Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI for constraint deletion #295

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Fix UI for constraint deletion #295

merged 1 commit into from
Oct 11, 2019

Conversation

zhouzhuojie
Copy link
Collaborator

@zhouzhuojie zhouzhuojie commented Oct 11, 2019

Description

Fix #290

Tested locally.

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@zhouzhuojie zhouzhuojie requested review from ScottDuane and a team October 11, 2019 02:30
@codecov-io
Copy link

Codecov Report

Merging #295 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #295   +/-   ##
======================================
  Coverage    81.8%   81.8%           
======================================
  Files          26      26           
  Lines        1533    1533           
======================================
  Hits         1254    1254           
  Misses        210     210           
  Partials       69      69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be93658...7d673cc. Read the comment docs.

@zhouzhuojie zhouzhuojie merged commit f106032 into master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI appears to delete the wrong constraint
4 participants