Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config option to exclude URLs from verbose middleware logging #375

Merged

Conversation

pacoguzman
Copy link
Contributor

Add configurable option to exclude URLs from verbose middleware logging

Description

We added MiddlewareVerboseLoggerExcludeURLs env where excluded urls can be specified as a list of string comma separated. We configure the middleware logging with this configuration setting.

Motivation and Context

Currently we have integrated Flagr on our infrastructure and we wanted to remove logging entries for not relevant urls like health check or metrics. So we can focus on relevant ones.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Merging #375 into master will decrease coverage by 0.09%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   81.80%   81.70%   -0.10%     
==========================================
  Files          26       26              
  Lines        1533     1536       +3     
==========================================
+ Hits         1254     1255       +1     
- Misses        210      211       +1     
- Partials       69       70       +1     
Impacted Files Coverage Δ
pkg/config/middleware.go 63.50% <50.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2668d5c...797d854. Read the comment docs.

@zhouzhuojie zhouzhuojie merged commit e204032 into openflagr:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants