Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margin on compact class #399

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Conversation

zakazai
Copy link
Contributor

@zakazai zakazai commented Sep 10, 2020

Remove margin on .compact class to add more space between timestamp and updated by section

Description

Before
Screen Shot 2020-09-10 at 16 29 39

After removing margin
Screen Shot 2020-09-10 at 16 29 53

Motivation and Context

I've setup Flagr using HTTP Header auth, when I saw the Flag history page, I noticed that the gap between snapshot's timestamp and updated by is too narrow. Removing margin seems solve this issue. Also this removal won't affect snapshot without updated by section as it's using different CSS class

How Has This Been Tested?

Tested on local using these browsers :

  • Google Chrome Version 85.0.4183.83 (Official Build) (64-bit)
  • Firefox 80.0.1 (64-bit)
  • Safari Version 13.1.2 (15609.3.5.1.3)

Types of changes

UI change

@codecov-commenter
Copy link

Codecov Report

Merging #399 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #399   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files          27       27           
  Lines        1755     1755           
=======================================
  Hits         1457     1457           
  Misses        214      214           
  Partials       84       84           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9395d...8d5b739. Read the comment docs.

Copy link
Collaborator

@zhouzhuojie zhouzhuojie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhouzhuojie zhouzhuojie merged commit 1fad37d into openflagr:master Sep 10, 2020
@zakazai zakazai deleted the patch-1 branch September 11, 2020 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants