Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic frontend for displaying list of feature flags on front page… #9

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

lucidrains
Copy link
Contributor

…, with ability to click into a feature flag for additional information

Copy link
Collaborator

@zhouzhuojie zhouzhuojie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment about the :id route. LGTM

component: Flags
},
{
path: '/flags/:id',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit, s/:id/:flagID, may want to keep it the same as the definition of swagger.yml

…, with ability to click into a feature flag for additional information
@lucidrains lucidrains force-pushed the pw/add-flag-creation-crud branch from 554f252 to 8fba299 Compare October 6, 2017 03:52
@lucidrains lucidrains merged commit 71e88fc into master Oct 6, 2017
@lucidrains lucidrains deleted the pw/add-flag-creation-crud branch October 6, 2017 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants