Skip to content

Commit

Permalink
Issue #6771: use 'violation'/'problem' term in it/resources instead o…
Browse files Browse the repository at this point in the history
…f 'error'
  • Loading branch information
romani committed Aug 30, 2019
1 parent 88a7991 commit 8561843
Show file tree
Hide file tree
Showing 9 changed files with 19 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ void ALL_UPPERCASE_METHOD()
// long line that has a tab -> <- and would be OK if tab counted as 1 char //warn
// tabs that count as one char because of their position -> <- -> <- //warn

/** some lines to test the error column after tabs */
void errorColumnAfterTabs()
/** some lines to test the column after tabs */
void violateColumnAfterTabs()
{
// with tab-width 8 all statements below start at the same column,
// with different combinations of ' ' and '\t' before the statement
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ void ALL_UPPERCASE_METHOD()
// long line that has a tab -> <- and would be OK if tab counted as 1 char
// tabs that count as one char because of their position -> <- -> <-, OK

/** some lines to test the error column after tabs */
void errorColumnAfterTabs()
/** some lines to test the column after tabs */
void violateColumnAfterTabs()
{
// with tab-width 8 all statements below start at the same column,
// with different combinations of ' ' and '\t' before the statement
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ public void foo4() {
String.CASE_INSENSITIVE_ORDER.equals("My number is greater than yours");
}
} else {
String.CASE_INSENSITIVE_ORDER.equals("Error!");
String.CASE_INSENSITIVE_ORDER.equals("Violation!");
}
}
} while( user != prog );
} else {
String.CASE_INSENSITIVE_ORDER.equals("Error!");
String.CASE_INSENSITIVE_ORDER.equals("Violation!");
}
String.CASE_INSENSITIVE_ORDER.equals("Goodbye!");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ public void foo4() {
String.CASE_INSENSITIVE_ORDER.equals("My number is greater than yours");
}
} else {
String.CASE_INSENSITIVE_ORDER.equals("Error!");
String.CASE_INSENSITIVE_ORDER.equals("Violation!");
}
}
} while( user != prog );
} else {
String.CASE_INSENSITIVE_ORDER.equals("Error!");
String.CASE_INSENSITIVE_ORDER.equals("Violation!");
}
String.CASE_INSENSITIVE_ORDER.equals("Goodbye!");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ void ALL_UPPERCASE_METHOD()
// long line that has a tab -> <- and would be OK if tab counted as 1 char
// tabs that count as one char because of their position -> <- -> <-, OK

/** some lines to test the error column after tabs */
void errorColumnAfterTabs()
/** some lines to test the column after tabs */
void violateColumnAfterTabs()
{
// with tab-width 8 all statements below start at the same column,
// with different combinations of ' ' and '\t' before the statement
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

/**
* Class for testing whitespace issues.
* error missing author tag
* violation missing author tag
**/
class InputWhitespaceAroundBasic
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ void foo1() {}
*/
void foo2() {}

/** @throws CheckstyleException if an error occurs */ //warn
/** @throws CheckstyleException if a problem occurs */ //warn
void foo3() {}

/**
* @throws CheckstyleException if an error occurs
* @throws CheckstyleException if a problem occurs
*/
void foo4() {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ void foo3() {}

/**
* This is valid.
* @throws Exception if an error occurs.
* @throws Exception if a problem occurs.
*/
void foo4() throws Exception {}

Expand Down Expand Up @@ -66,7 +66,7 @@ void foo3() {}

/**
* This is valid.
* @throws Exception if an error occurs.
* @throws Exception if a problem occurs.
*/
void foo4() throws Exception {}

Expand Down Expand Up @@ -110,7 +110,7 @@ void foo3() {}

/**
* This is valid.
* @throws Exception if an error occurs.
* @throws Exception if a problem occurs.
*/
void foo4() throws Exception {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class InputIncorrectSummaryJavaDocCheck {
void foo3() {}

/*warn*//**
* @throws Exception if an error occurs
* @throws Exception if a problem occurs
*/
void foo4() throws Exception {}

Expand Down Expand Up @@ -67,7 +67,7 @@ void foo2() {}
void foo3() {}

/*warn*//**
* @throws Exception if an error occurs
* @throws Exception if a problem occurs
*/
void foo4() throws Exception {}

Expand Down Expand Up @@ -101,7 +101,7 @@ void emulated(String s) {}
void foo3() {}

/*warn*//**
* @throws Exception if an error occurs
* @throws Exception if a problem occurs
*/
void foo4() throws Exception {}

Expand Down

0 comments on commit 8561843

Please sign in to comment.