Issue #6771: use 'violation'/'problem' term in it/resources instead of 'error'

Author: romani

src/it/resources/com/google/checkstyle/test/chapter2filebasic/rule231filetab/InputFileTabCharacter.java

@@ -121,8 +121,8 @@ void ALL_UPPERCASE_METHOD()
     // long line that has a tab ->	<- and would be OK if tab counted as 1 char //warn
     // tabs that count as one char because of their position ->	<-   ->	<- //warn
 
-    /** some lines to test the error column after tabs */
-    void errorColumnAfterTabs()
+    /** some lines to test the column after tabs */
+    void violateColumnAfterTabs()
     {
         // with tab-width 8 all statements below start at the same column,
         // with different combinations of ' ' and '\t' before the statement

src/it/resources/com/google/checkstyle/test/chapter3filestructure/rule332nolinewrap/InputLineLength.java

@@ -131,8 +131,8 @@ void ALL_UPPERCASE_METHOD()
     // long line that has a tab ->    <- and would be OK if tab counted as 1 char
     // tabs that count as one char because of their position ->    <-   ->    <-, OK
 
-    /** some lines to test the error column after tabs */
-    void errorColumnAfterTabs()
+    /** some lines to test the column after tabs */
+    void violateColumnAfterTabs()
     {
         // with tab-width 8 all statements below start at the same column,
         // with different combinations of ' ' and '\t' before the statement

src/it/resources/com/google/checkstyle/test/chapter4formatting/rule412nonemptyblocks/InputRightCurlyDoWhile.java

@@ -47,12 +47,12 @@ public void foo4() {
                             String.CASE_INSENSITIVE_ORDER.equals("My number is greater than yours");
                         }
                     } else {
-                        String.CASE_INSENSITIVE_ORDER.equals("Error!");
+                        String.CASE_INSENSITIVE_ORDER.equals("Violation!");
                     }
                 }
             } while( user != prog );
         } else {
-            String.CASE_INSENSITIVE_ORDER.equals("Error!");
+            String.CASE_INSENSITIVE_ORDER.equals("Violation!");
         }
         String.CASE_INSENSITIVE_ORDER.equals("Goodbye!");
     }

src/it/resources/com/google/checkstyle/test/chapter4formatting/rule412nonemptyblocks/InputRightCurlyDoWhileAlone.java

@@ -47,12 +47,12 @@ public void foo4() {
                             String.CASE_INSENSITIVE_ORDER.equals("My number is greater than yours");
                         }
                     } else {
-                        String.CASE_INSENSITIVE_ORDER.equals("Error!");
+                        String.CASE_INSENSITIVE_ORDER.equals("Violation!");
                     }
                 }
             } while( user != prog );
         } else {
-            String.CASE_INSENSITIVE_ORDER.equals("Error!");
+            String.CASE_INSENSITIVE_ORDER.equals("Violation!");
         }
         String.CASE_INSENSITIVE_ORDER.equals("Goodbye!");
     }

src/it/resources/com/google/checkstyle/test/chapter4formatting/rule44columnlimit/InputLineLength.java

@@ -131,8 +131,8 @@ void ALL_UPPERCASE_METHOD()
     // long line that has a tab ->    <- and would be OK if tab counted as 1 char
     // tabs that count as one char because of their position ->    <-   ->    <-, OK
 
-    /** some lines to test the error column after tabs */
-    void errorColumnAfterTabs()
+    /** some lines to test the column after tabs */
+    void violateColumnAfterTabs()
     {
         // with tab-width 8 all statements below start at the same column,
         // with different combinations of ' ' and '\t' before the statement

src/it/resources/com/google/checkstyle/test/chapter4formatting/rule462horizontalwhitespace/InputWhitespaceAroundBasic.java

@@ -2,7 +2,7 @@
 
 /**
  * Class for testing whitespace issues.
- * error missing author tag
+ * violation missing author tag
  **/
 class InputWhitespaceAroundBasic
 {

src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule711generalform/InputSingleLineJavadocCheck.java

@@ -10,11 +10,11 @@ void foo1() {}
      */
     void foo2() {}
 
-    /** @throws CheckstyleException if an error occurs */ //warn
+    /** @throws CheckstyleException if a problem occurs */ //warn
     void foo3() {}
 
     /**
-     * @throws CheckstyleException if an error occurs
+     * @throws CheckstyleException if a problem occurs
      */
     void foo4() {}
 

src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule72thesummaryfragment/InputCorrectSummaryJavaDocCheck.java

@@ -17,7 +17,7 @@ void foo3() {}
 
     /**
      * This is valid.
-     * @throws Exception if an error occurs.
+     * @throws Exception if a problem occurs.
      */
     void foo4() throws Exception {}
 
@@ -66,7 +66,7 @@ void foo3() {}
 
         /**
          * This is valid.
-         * @throws Exception if an error occurs.
+         * @throws Exception if a problem occurs.
          */
         void foo4() throws Exception {}
 
@@ -110,7 +110,7 @@ void foo3() {}
 
         /**
          * This is valid.
-         * @throws Exception if an error occurs.
+         * @throws Exception if a problem occurs.
          */
         void foo4() throws Exception {}
 

src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule72thesummaryfragment/InputIncorrectSummaryJavaDocCheck.java

@@ -12,7 +12,7 @@ class InputIncorrectSummaryJavaDocCheck {
     void foo3() {}
 
 /*warn*//**
-     * @throws Exception if an error occurs
+     * @throws Exception if a problem occurs
      */
     void foo4() throws Exception {}
 
@@ -67,7 +67,7 @@ void foo2() {}
         void foo3() {}
 
 /*warn*//**
-         * @throws Exception if an error occurs
+         * @throws Exception if a problem occurs
          */
         void foo4() throws Exception {}
 
@@ -101,7 +101,7 @@ void emulated(String s) {}
         void foo3() {}
 
 /*warn*//**
-         * @throws Exception if an error occurs
+         * @throws Exception if a problem occurs
          */
         void foo4() throws Exception {}