Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build from source #257

Closed
jalmeroth opened this issue Oct 7, 2023 · 4 comments
Closed

Unable to build from source #257

jalmeroth opened this issue Oct 7, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@jalmeroth
Copy link

Describe the bug
I am unable to build phanpy from source by dowloading an artifact (tar/zip) from tags.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/cheeaun/phanpy/tags
  2. Click on any tar.gz link
  3. Unpack the downloaded file
  4. Change into phanpy-$version folder
  5. Try to npm install, npm run build

Expected behavior
You get a clean, distributable version of phanpy as described in Self Hosting

Error message

$ npm run build

> phanpy@0.1.0 build
> vite build

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
failed to load config from /tmp/tmp.bxIPUvnwZt/phanpy-2023.10.07.9b1800d/vite.config.js
error during build:
Error: Command failed: git rev-parse --short HEAD
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

    at checkExecSyncError (node:child_process:890:11)
    at execSync (node:child_process:962:15)
    at file:///tmp/tmp.bxIPUvnwZt/phanpy-2023.10.07.9b1800d/vite.config.js.timestamp-1696719649450-96852b13653e5.mjs:19:18
    at ModuleJob.run (node:internal/modules/esm/module_job:194:25)
@cheeaun cheeaun added the bug Something isn't working label Oct 8, 2023
@cheeaun
Copy link
Owner

cheeaun commented Nov 8, 2023

Tags now have Releases. It's pre-built, without the need to run npm run build on your end. Let me know if this works

@jalmeroth
Copy link
Author

Perfect! That's even better then buildung it myself. Thank you! 👍

@jalmeroth
Copy link
Author

Ah, one remark: would it be possible to ship a .tar or .tar.gz additionally/exclusively?
This would streamline my Dockerfile since nginx comes with curl and tar, but not with unzip.

Thanks for considering!

@jalmeroth jalmeroth reopened this Nov 8, 2023
@jalmeroth
Copy link
Author

Awesome @cheeaun, thank you!

FROM docker.io/library/nginx:latest
WORKDIR /usr/share/nginx/html
RUN \
curl -sSOL https://github.com/cheeaun/phanpy/releases/latest/download/phanpy-dist.tar.gz \
&& tar -xf phanpy-dist.tar.gz \
&& rm phanpy-dist.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants