Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway timeouts after starting a job #25

Open
david-crowder opened this issue Feb 25, 2015 · 4 comments
Open

Gateway timeouts after starting a job #25

david-crowder opened this issue Feb 25, 2015 · 4 comments
Assignees
Labels
Type: Bug Doesn't work as expected.

Comments

@david-crowder
Copy link

I am having issues with running push jobs. Currently, most of the times I start a job it winds up timing out while checking the status. The status seems to be polled more frequently than need be:
https://github.com/chef/knife-push/blob/master/lib/chef/knife/job_start.rb#L98

Is there some way to make knife-push retry when met with a gateway timeout?

@david-crowder
Copy link
Author

Looking through the source, it seems like the rest call should be retrying if it hits networking issues:
https://github.com/chef/chef/blob/master/lib/chef/http.rb#L288

@sean-horn
Copy link

Zendesk 2641

@markan markan added the bug label Apr 16, 2015
@markan markan added this to the Accepted Patch milestone Apr 16, 2015
@markan
Copy link
Contributor

markan commented Apr 16, 2015

What version of chef/knife are you using? Older versions didn't retry, but the newer versions should, as you pointed out above.

I agree that the polling is too frequent. I'm going to back that off, maybe to 1 sec. When version 2.0 of push server is released we can switch to using the SSE feed and stop the polling entirely.

@david-crowder
Copy link
Author

Thanks for looking into this and making the PR @manderson26
The version of knife is 11.18.6. I am excited to see what push server 2.0 will bring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Doesn't work as expected.
Development

No branches or pull requests

4 participants