Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Today (2023-01-14) README.md typo? #1464

Closed
rubisher opened this issue Jan 14, 2023 · 1 comment
Closed

Today (2023-01-14) README.md typo? #1464

rubisher opened this issue Jan 14, 2023 · 1 comment
Assignees
Labels
Status: Untriaged An issue that has yet to be triaged.

Comments

@rubisher
Copy link

Version

[rudy@rl8-vgr2 bento]$ git log -n 1
commit 3dca3da (HEAD -> main, origin/main, origin/HEAD)
Author: Corey Hemminger hemminger@hotmail.com
Date: Mon Jan 9 18:04:35 2023 -0600

Environment

VirualBox-7.0 Rockylinux 8.7 guest

Scenario

Create my custom vagrant box image based on bento templates.

Steps to Reproduce

the github Readme.md mentioned:
*NOTE: Virutalbox 7.x requires extra config to allow nat network to connect to the host. To use uncomment lines #79 and #80 in bento/packer_templates/pkr-sources.pkr.hcl

While it seems to be better bento/packer_templates/pkr-variables.pkr.hcl file which would required to uncomment line #154 & #155?

Expected Result

Reading note:
*NOTE: Virutalbox 7.x requires extra config to allow nat network to connect to the host. To use uncomment lines #154 and #155 in bento/packer_templates/pkr-variables.pkr.hcl

Additional comment:

Couldn't we merge this 2 lines ?

@rubisher rubisher added the Status: Untriaged An issue that has yet to be triaged. label Jan 14, 2023
@Stromweld
Copy link
Collaborator

Thanks for the catch fixing this in latest PR #1465

@Stromweld Stromweld self-assigned this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Untriaged An issue that has yet to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants